From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37E6B1EB19D for ; Mon, 3 Mar 2025 08:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740991067; cv=none; b=XheA/gxPs2DSpuRQ5lItgzZUorDJmwM+e57RevuF8ynAxtoyKCbXYQ63N7bMd3nHA5lccK9ABHRiuYD7XAgBq8Dant5MWqw115Mhu0B7jAqjkESFbW9HHbCHva1I2p5B4gLZi6nIL362B4l1v4qDelGivYNMiLrsv/h++HYKAjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740991067; c=relaxed/simple; bh=RK+QYQOjVVok1aZddoO9G5Ba4alVGQm4Od6mXZJOVrI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UJxFRBJpwnyI0Q2fu/2tk5GRQnl7XGP9lcYsMhldraIGLDxsIZY2Fc9Ok8yivuHAsaRHBBqi4tdj2x8o2bZ2r9RUIMDMP+lMJlv8sai3GdVKGcmwbON7QzZ1HI2sSgtYDPcYGHq3SC0wj0S2TxwrK3Z9OshQVmCJjz4Qrwfumhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=GTwMmdPn; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="GTwMmdPn" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aaecf50578eso790469366b.2 for ; Mon, 03 Mar 2025 00:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1740991063; x=1741595863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=088gCiVsmCpfljLz/WNF5os3OZWs6Dr62hIApojY3d8=; b=GTwMmdPnOt4JdMYnuZd0BMPrJfhOGVMFGyaIt30eGyGKH88mrDBAzuCfb/8W5gXcoy Fi0uy9lBo5b+sX6jQwzO/TDHvHWK+HQ1iD2HimnqoKKc3X9eeKxHTqBk7fAMzKMe7ITd GNspcevs36/PtIIe/M4DnImUflW+aYnaeFBZ2YhmvcrpsGZFM7rNmzpGAJqBJ1tfWeC+ L/h+qu3fKXDM9nLcrDaz281esofKd3ZoO1E+e7XW9UMkROxWf0HeLO8RKiKKWwvyXNf7 K8v7lThakNbJ8u5gSwcEum02YRFL0CJc2ABSIZROxqE9G47oFCC9y5epW7El/7yx/rIP TR6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740991063; x=1741595863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=088gCiVsmCpfljLz/WNF5os3OZWs6Dr62hIApojY3d8=; b=NeUGV4DOmM/msaYlS61lEwMfI74Uyohy7pt9NsOSW9YwJcgb5+1Jx7CnQ0MaY+qt8R N/8/ynK9WLLbKC6+/JPdLA9zwWr74f/A/G6OUJkbs2j3CFPH5zruLJuMQpMGKTGwN8E6 DZHmWT5rkejxkFu+oNIGOJdqYsGf2OYqed7ODgifKejhCEZPeWSbf5bTPVbo3+lmtPBp PcyH9jT0Lis/iuCnf+uubRC2GIArhsnIo1UFFn/VgGyteojTuefk8S3ntuJ6xuXjfjy+ QCviG2zI3NC9cZjEavAGPla6OBovQQrTz+lA+VEhiMrteW5EIE9LtnuXUQK1/aw/Eb0x T0ew== X-Forwarded-Encrypted: i=1; AJvYcCUAEWk5mLRMRiwhyvOzgPMj/k84kNTETEDjcPMk4Z4FM1xcn+49u3ByLaaR89LOQS1G1MYJ9IBl5lx3@vger.kernel.org X-Gm-Message-State: AOJu0YxCw3WRQm212kEJo8GXQTihIvuSdaxg6sDGjVscJuSgL2JfxzGX FgEkGA7mB6E2wZ3fm4OvtY9YkrUS1+nw9q8W2inALkSZlxzhqR23PTkVk5Ua1tU= X-Gm-Gg: ASbGncutQz3ZKouz2mPiGmYI7bMfuLoQyh5eZ5uboAOfBKIqkTgcEX4r2COW67ZvUnc x5VOdcFplPok+VMKxcRKg5kVluWygSfVFTofVq7sZvzkrysuAsFRnJa9rHyLxw8pzUsMhSJ2Ybn qTMEi9KV+BOU5fH5s+IdQPn+hN96K1Yz97BKZJjYYbP638Z/ZuM0CtbScOy8cUe0ljL4pV0hKbW S8zlHIgdBTIELvfGi/4UTIVZ68rahcOrazL79RYYfiG3XzqGmSwZqEA+x2LZvOh3lx9gEXz28V6 A5NPAbPgF3bZefJDYW/xIyudzulCTEbBRfW68+dl6zDUL3D1vySkZPh4 X-Google-Smtp-Source: AGHT+IG+mwXTx4eDAQj8AAOugFy3UaMktA3JlzKQWx74RnnVc1/k+KU8S1qfjCYJPEbQsqpxnNFduw== X-Received: by 2002:a17:906:6a28:b0:abf:749f:f719 with SMTP id a640c23a62f3a-abf749ffc45mr408409866b.7.1740991063333; Mon, 03 Mar 2025 00:37:43 -0800 (PST) Received: from [192.168.50.159] ([82.78.167.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf19aca8a0sm730375166b.178.2025.03.03.00.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 00:37:42 -0800 (PST) Message-ID: <45713e88-57af-43c7-bf0b-4583383b10dc@tuxon.dev> Date: Mon, 3 Mar 2025 10:37:43 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/21] ARM: at91: PM: Add Backup mode for SAMA7D65 To: Ryan.Wanner@microchip.com, lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sre@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, p.zabel@pengutronix.de Cc: linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org References: <3a1f59af1ac9322b0203694b535d5d13120a31eb.1740671156.git.Ryan.Wanner@microchip.com> Content-Language: en-US From: "claudiu beznea (tuxon)" In-Reply-To: <3a1f59af1ac9322b0203694b535d5d13120a31eb.1740671156.git.Ryan.Wanner@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/27/25 17:51, Ryan.Wanner@microchip.com wrote: > From: Ryan Wanner > > Add config check that enables Backup mode for SAMA7D65 SoC. > > Add SHDWC_SR read to clear the status bits once finished exiting backup > mode. This is only for SAMA7D65 SoCs. The SHDWC status register > needs to be cleared after exiting backup mode to clear the wake up pin > status. > > Signed-off-by: Ryan Wanner > --- > arch/arm/mach-at91/pm.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index 39644703244d..d82a507bc8da 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -647,6 +647,11 @@ static void at91_pm_suspend(suspend_state_t state) > at91_suspend_sram_fn = fncpy(at91_suspend_sram_fn, > &at91_pm_suspend_in_sram, > at91_pm_suspend_in_sram_sz); > + > + if (IS_ENABLED(CONFIG_SOC_SAMA7D65)) > + /* SHDWC.SR */ > + readl(soc_pm.data.shdwc + 0x08); > + > } else { > at91_suspend_finish(0); > } > @@ -707,6 +712,7 @@ static int at91_pm_enter(suspend_state_t state) > static void at91_pm_end(void) > { > at91_pm_config_ws(soc_pm.data.mode, false); > + Not needed. I'll drop it while applying. > } > > > @@ -1065,7 +1071,8 @@ static int __init at91_pm_backup_init(void) > int ret = -ENODEV, located = 0; > > if (!IS_ENABLED(CONFIG_SOC_SAMA5D2) && > - !IS_ENABLED(CONFIG_SOC_SAMA7G5)) > + !IS_ENABLED(CONFIG_SOC_SAMA7G5) && > + !IS_ENABLED(CONFIG_SOC_SAMA7D65)) > return -EPERM; > > if (!at91_is_pm_mode_active(AT91_PM_BACKUP))