From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Cc: sre@kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
linux@roeck-us.net, andersson@kernel.org, konradybcio@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
bryan.odonoghue@linaro.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
neil.armstrong@linaro.org, gaurav.kohli@oss.qualcomm.com,
manaf.pallikunhi@oss.qualcomm.com,
priyansh.jain@oss.qualcomm.com
Subject: Re: [PATCH v5 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support
Date: Tue, 7 Jul 2026 10:09:17 +0200 [thread overview]
Message-ID: <457242e3-6a40-49a2-8d86-214f9167a928@kernel.org> (raw)
In-Reply-To: <8d579153-efa5-4c8e-acae-87f3bdfbfc24@oss.qualcomm.com>
On 07/07/2026 10:08, Daniel Lezcano wrote:
> On 7/7/26 08:38, Krzysztof Kozlowski wrote:
>> On Mon, Jul 06, 2026 at 08:46:46PM +0200, Daniel Lezcano wrote:
>>> Document the Lenovo ThinkPad T14s Embedded Controller as a thermal
>>> sensor provider by adding the '#thermal-sensor-cells' property.
>>>
>>> This allows the EC temperature sensors to be referenced from thermal
>>> zones in the device tree.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>>> ---
>>> .../embedded-controller/lenovo,thinkpad-t14s-ec.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> index c87ccb5b3086..0d049979e35b 100644
>>> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> @@ -26,10 +26,14 @@ properties:
>>>
>>> wakeup-source: true
>>>
>>> + "#thermal-sensor-cells":
>>> + const: 1
>>> +
>>> required:
>>> - compatible
>>> - reg
>>> - interrupts
>>> + - "#thermal-sensor-cells"
>>
>> This looks like ABI break without explanation.
>
> What would you suggest ? explanation or removed from required properties?
I don't know what is the explanation. If this is actual ABI break as I
read Linux code, what is the rationale behind breaking real users?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-07 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 18:46 [PATCH v5 0/3] Lenovo ThinkPad T14s EC thermal monitoring and thermal zone integration Daniel Lezcano
2026-07-06 18:46 ` [PATCH v5 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support Daniel Lezcano
2026-07-06 18:57 ` sashiko-bot
2026-07-07 6:38 ` Krzysztof Kozlowski
2026-07-07 8:08 ` Daniel Lezcano
2026-07-07 8:09 ` Krzysztof Kozlowski [this message]
2026-07-07 8:20 ` Daniel Lezcano
2026-07-06 18:46 ` [PATCH v5 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures Daniel Lezcano
2026-07-06 18:55 ` sashiko-bot
2026-07-06 19:29 ` Dmitry Baryshkov
2026-07-07 6:39 ` Krzysztof Kozlowski
2026-07-06 18:46 ` [PATCH v5 3/3] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors Daniel Lezcano
2026-07-06 18:53 ` sashiko-bot
2026-07-06 19:27 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457242e3-6a40-49a2-8d86-214f9167a928@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=gaurav.kohli@oss.qualcomm.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manaf.pallikunhi@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=priyansh.jain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox