From: Heiko Stuebner <heiko@sntech.de>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
jwerner@chromium.org, huangtao@rock-chips.com,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi
Date: Wed, 17 Feb 2016 07:45:09 +0100 [thread overview]
Message-ID: <4579617.rz6Yi2sU5M@phil> (raw)
In-Reply-To: <56C3BD26.3030704@rock-chips.com>
Hi Jianqun,
Am Mittwoch, 17. Februar 2016, 08:21:58 schrieb Jianqun Xu:
> 在 16/02/2016 22:37, Heiko Stuebner 写道:
> > Am Dienstag, 16. Februar 2016, 13:22:23 schrieb Mark Brown:
> >> On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote:
> >>> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>
> >> I'd expect this to be added to both the driver and the binding document
> >> not just the document.
> >
> > It seems the driver can still use the rk3066-variant - aka nobody has
> > found specific issues in the rk3399 IP implementation.
> >
> > Having the more specific IP names already in the dts before actually
> > using them was suggested by devicetree people to not have to exchange
> > everything once specific issues were found.
> >
> > So right now it's using the fallback-mechanism of binding to the rk3066
> > name, but if some obstacle appears it will only take adding the binding
> > in the driver to make it work (even with old devicetrees).
>
> Thank you, got it, and I will re-send this patch with the driver patch.
you have me confused now :-) .
That was meant as a reply to Mark's comment, explaining why the double
compatible and the driver only binding to the rk3066-one right now.
Heiko
next prev parent reply other threads:[~2016-02-17 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 9:22 [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi jianqun.xu
[not found] ` <1455614538-4415-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-02-16 13:22 ` Mark Brown
2016-02-16 14:37 ` Heiko Stuebner
2016-02-17 0:21 ` Jianqun Xu
2016-02-17 6:45 ` Heiko Stuebner [this message]
2016-02-17 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4579617.rz6Yi2sU5M@phil \
--to=heiko@sntech.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jay.xu@rock-chips.com \
--cc=jwerner@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).