From: "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
jdelvare@suse.com, p.zabel@pengutronix.de,
linux-hwmon@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
songjun.Wu@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, rtanwar@maxlinear.com
Subject: Re: [PATCH 2/2] Add driver for Moortec MR75203 PVT controller
Date: Thu, 10 Sep 2020 17:53:57 +0800 [thread overview]
Message-ID: <457b8ff8-4093-3b82-5358-4b8460a1b012@linux.intel.com> (raw)
In-Reply-To: <20200910094622.GO1891694@smile.fi.intel.com>
On 10/9/2020 5:46 pm, Andy Shevchenko wrote:
> On Thu, Sep 10, 2020 at 03:27:11PM +0800, Tanwar, Rahul wrote:
>> On 9/9/2020 11:05 pm, Guenter Roeck wrote:
>>> On 9/8/20 11:52 PM, Rahul Tanwar wrote:
> ...
>
>>>> +static int pvt_get_regmap(struct platform_device *pdev, char *reg_name)
>>>> +{
>>>> + struct device *dev = &pdev->dev;
>>>> + struct pvt_device *pvt = platform_get_drvdata(pdev);
>>> I am quite at loss how this is supposed to work. Platform driver
>>> data is not initialized with a pointer to struct pvt_device at this point.
>>> How does this code not crash ? What am I missing ?
>> Big mistake on my part. Last minute change based on internal review feedback
>> about moving platform_set_drvdata() at the end of probe. I will fix it in v2.
>> Thanks.
> Since IIRC it was me who suggested this I should say that reviewer can make
> mistakes, on the other hand contributor should have had known their code to
> refuse certain changes.
>
Totally agree. Overlooked in a hasty change..
Regards,
Rahul
next prev parent reply other threads:[~2020-09-10 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 6:52 [PATCH 0/2] Add driver for Moortec PVT controller Rahul Tanwar
2020-09-09 6:52 ` [PATCH 1/2] Add DT bindings schema for " Rahul Tanwar
2020-09-09 20:48 ` Rob Herring
2020-09-09 6:52 ` [PATCH 2/2] Add driver for Moortec MR75203 " Rahul Tanwar
2020-09-09 10:33 ` Andy Shevchenko
2020-09-10 7:26 ` Tanwar, Rahul
2020-09-10 9:33 ` Andy Shevchenko
2020-09-09 15:05 ` Guenter Roeck
[not found] ` <c72665ba-b594-bbb0-00c5-ed763233d609@linux.intel.com>
2020-09-10 9:34 ` Guenter Roeck
2020-09-10 9:46 ` Andy Shevchenko
2020-09-10 9:53 ` Tanwar, Rahul [this message]
2020-09-10 10:35 ` Philipp Zabel
2020-09-10 10:42 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457b8ff8-4093-3b82-5358-4b8460a1b012@linux.intel.com \
--to=rahul.tanwar@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=songjun.Wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).