Re: [PATCH v4 3/7] clk: qcom: gcc-msm8916: use ARRAY_SIZE instead of specifying num_parents

[Georgi Djakov <djakov@kernel.org>]

On 4.07.22 20:24, Dmitry Baryshkov wrote:
> Use ARRAY_SIZE() instead of manually specifying num_parents. This makes
> adding/removing entries to/from parent_data easy and errorproof.
> 
> This conversion fixes an issue present since the first version of this
> driver. For the gp1_clk_src, gp2_clk_src and gp3_clk_src it was
> impossible to select sleep_clk as a prent of the clock, since
> num_parents was limited to 3 rather than 4. Switching to use num_parents
> automatically makes sleep_clk available for selection.

Thanks for fixing it!

> Fixes: 3966fab8b6ab ("clk: qcom: Add MSM8916 Global Clock Controller support")
> Cc: Georgi Djakov <djakov@kernel.org>
> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Acked-by: Georgi Djakov <djakov@kernel.org>

> ---
>   drivers/clk/qcom/gcc-msm8916.c | 108 ++++++++++++++++-----------------
>   1 file changed, 54 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
> index 9a46794f6eb8..265df21e24af 100644
> --- a/drivers/clk/qcom/gcc-msm8916.c
[..]