From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v3 1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
Date: Tue, 19 Dec 2023 08:17:28 +0100 [thread overview]
Message-ID: <457e336e-004c-4721-b58d-e9ada16dc04b@linaro.org> (raw)
In-Reply-To: <20231219003106.8663-2-quic_tengfan@quicinc.com>
On 19/12/2023 01:31, Tengfei Fan wrote:
> The address/size-cells in mdss_dsi1 node have not ranges and child also
> have not reg, then this leads to dtc W=1 warnings:
I cannot parse it. Address/size cells never have ranges or children.
They cannot have. These are uint32 properties.
>
> sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
> unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
I disagreed with the patch before. You resubmit it without really
addressing my concerns.
I am not sure if this is correct fix and I want to fix all of such
errors (there are multiple of them) in the same way. Feel free to
propose common solution based on arguments.
I don't really want to NAKit but since you are resending without
finishing the discussion, which is quite impolite, then let's be like that:
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-19 7:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 0:31 [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove Tengfei Fan
2023-12-19 0:31 ` [PATCH v3 1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1 Tengfei Fan
2023-12-19 7:17 ` Krzysztof Kozlowski [this message]
2023-12-19 7:42 ` Tengfei Fan
2023-12-19 9:36 ` Aiqun Yu (Maria)
2023-12-19 9:41 ` Krzysztof Kozlowski
2023-12-19 10:09 ` Aiqun Yu (Maria)
2023-12-19 10:13 ` Krzysztof Kozlowski
2023-12-19 10:21 ` Dmitry Baryshkov
2023-12-20 0:53 ` Aiqun Yu (Maria)
2023-12-20 7:06 ` Dmitry Baryshkov
2023-12-20 10:33 ` Aiqun Yu (Maria)
2023-12-20 11:10 ` Dmitry Baryshkov
2023-12-21 1:57 ` Aiqun Yu (Maria)
2023-12-21 6:59 ` Dmitry Baryshkov
2023-12-21 8:49 ` Aiqun Yu (Maria)
2023-12-21 8:57 ` Krzysztof Kozlowski
2023-12-22 9:10 ` Aiqun Yu (Maria)
2023-12-22 9:30 ` Krzysztof Kozlowski
2023-12-21 9:56 ` Dmitry Baryshkov
2023-12-20 11:20 ` Krzysztof Kozlowski
2023-12-20 7:10 ` Krzysztof Kozlowski
2023-12-19 19:33 ` (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove Bjorn Andersson
2023-12-20 5:34 ` Aiqun Yu (Maria)
2023-12-20 7:11 ` Krzysztof Kozlowski
2023-12-20 7:23 ` Dmitry Baryshkov
2023-12-20 12:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457e336e-004c-4721-b58d-e9ada16dc04b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).