From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] nvmem: Convert to using %pOF instead of full_name
Date: Thu, 10 Aug 2017 09:57:48 +0100 [thread overview]
Message-ID: <45abedcc-d343-2878-9cd2-a78df8fd3d88@linaro.org> (raw)
In-Reply-To: <CAL_Jsq+bJjdfdNjpx=URP4EHPJt=MDc2V-eVr8OaPAftVph4cg@mail.gmail.com>
On 09/08/17 23:14, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <robh@kernel.org> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> drivers/nvmem/core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Ping?
I have already sent this patch to Greg to queue up for next.
Thanks,
srini
>
>>
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index 4c49285168fb..b0c60338296a 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -794,8 +794,8 @@ struct nvmem_cell *of_nvmem_cell_get(struct device_node *np,
>>
>> addr = of_get_property(cell_np, "reg", &len);
>> if (!addr || (len < 2 * sizeof(u32))) {
>> - dev_err(&nvmem->dev, "nvmem: invalid reg on %s\n",
>> - cell_np->full_name);
>> + dev_err(&nvmem->dev, "nvmem: invalid reg on %pOF\n",
>> + cell_np);
>> rval = -EINVAL;
>> goto err_mem;
>> }
>> --
>> 2.11.0
>>
prev parent reply other threads:[~2017-08-10 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:43 [PATCH] nvmem: Convert to using %pOF instead of full_name Rob Herring
[not found] ` <20170718214339.7774-40-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-09 22:14 ` Rob Herring
2017-08-10 8:57 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45abedcc-d343-2878-9cd2-a78df8fd3d88@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).