From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E61F6C004D4 for ; Sat, 21 Jan 2023 18:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjAUSbd (ORCPT ); Sat, 21 Jan 2023 13:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbjAUSbc (ORCPT ); Sat, 21 Jan 2023 13:31:32 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA3A01D93B for ; Sat, 21 Jan 2023 10:31:30 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso6451812wmn.5 for ; Sat, 21 Jan 2023 10:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZwoDBvRhZ51HVwRruPaZJDCI07MDbJL4OZ/OSacJub4=; b=DXZKAycNcbv1iXdoy5RHgDDWZYz4w+4tSZhy7uzlZ9WRKzJP0NHHQJfd+DVK6/tnoH r0LTdWDEOFwGr8v5G0MY8ojjJ4DNAlLLqpbItFA0EFgwFJcEisGZ+af3rxoFmuCZIUy3 nX8GimRZPlWnpgUn/oFN7WktFnkdjfLqP4bWRObvDi/5Mj3sochYa7CCTEIjGWrZykPY 5eUcrPhUqIPQag//q7hEEA7V7NR/4nLP4zSA87Hd7j0GRbZxRbI7v8M8X64YSyad29En O0cAi0zkhFgAu3eqbW5Fsxiirur0CXaQB1EGjsZnxMPQqNtW1i0Qs6cPKlj3pP9GeBfr tVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZwoDBvRhZ51HVwRruPaZJDCI07MDbJL4OZ/OSacJub4=; b=cfeS+JkixBLJ2TH1Ae1S+PXyl4eTVzy5k9al9a9qphFMz8Mn0fj5V2XbnJ5GwidiHw DpXNcH1u4DQLiR5UhhbrUuMbK7BFfTRAWWtP422ykBf0QCkpgedicRpb4l0om5iwCf9e 3gvZ0Es/h3qr5H6JJYLKxoaKa2UJKLIG5NJaPreDBxYPfJK/70s5bsX8PPhEQZpf8xOJ OcY2dpFxBqQgGWmjghC4+wG9Wx5fmvVqHHMp/4f1fffFdH/YRja2JcPCayd5eQ3EfgaM Bn9Qzo1rnVbNIXqN1bFKRYu1CctrldhWbDsUoDR/2V3P4DXBJO8+5oXcIGUBI0WVV3+o MFYA== X-Gm-Message-State: AFqh2kpWUCzd1eZJxW4Ey0c9cTyDeDaMRytggvCcHmxLCW0xoZM18Ajh NsVOrXjKp4pwKB13mti7+8ZFjQ== X-Google-Smtp-Source: AMrXdXtzA0VhWJr5PaMDSwqlmcQOuGEVhWjqw2Lcr/7uvjQ2leyTYFBOPlCVPt9XkFdATbe08+PT5Q== X-Received: by 2002:a05:600c:5386:b0:3da:f670:a199 with SMTP id hg6-20020a05600c538600b003daf670a199mr18285088wmb.36.1674325889305; Sat, 21 Jan 2023 10:31:29 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c2-20020a05600c0a4200b003daf6e3bc2fsm16026540wmq.1.2023.01.21.10.31.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Jan 2023 10:31:28 -0800 (PST) Message-ID: <45b9b378-6619-c47a-b5ea-6b6b7edca785@linaro.org> Date: Sat, 21 Jan 2023 19:31:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 3/5] dt-bindings: iio: correct node names in examples To: Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Lucas Stankus , Puranjay Mohan , Dmitry Rokosov , Alexandru Tachici , Marcelo Schmitt , Renato Lui Geh , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Andreas Klinger , Marcus Folkesson , Kent Gustavsson , Lad Prabhakar , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Oleksij Rempel , kernel@pengutronix.de, =?UTF-8?Q?Nuno_S=c3=a1?= , Nishant Malpani , Rui Miguel Silva , Dragos Bogdan , Jean-Baptiste Maneyrol , Lorenzo Bianconi , Benson Leung , Guenter Roeck , Stefan Popa , Robert Yang , Sean Nyekjaer , Artur Rojek , Miquel Raynal , Philippe Reynes , Alexandru Lazar , Linus Walleij , Caleb Connolly , Fabrice Gasnier , Stefan Agner , Daniel Baluta , Harald Geyer , Eugene Zaikonnikov , Phil Reid , Matt Ranostay , Stephen Boyd , Sankar Velliangiri , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, chrome-platform@lists.linux.dev References: <20230118184413.395820-1-krzysztof.kozlowski@linaro.org> <20230118184413.395820-3-krzysztof.kozlowski@linaro.org> <20230121171709.5eb75e94@jic23-huawei> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230121171709.5eb75e94@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/01/2023 18:17, Jonathan Cameron wrote: > On Wed, 18 Jan 2023 19:44:11 +0100 > Krzysztof Kozlowski wrote: > >> Do not use underscores and unneeded suffixes (e.g. i2c0) in node name in >> examples. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > >> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml >> index 6c5ad426a016..12f75ddc4a70 100644 >> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml >> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml >> @@ -42,7 +42,7 @@ examples: >> #address-cells = <1>; >> #size-cells = <0>; >> >> - heart_mon@0 { >> + heart-rate@0 { > > These are both heart-rate and pulse oximeters so measure more than just > the rate (oxygen saturation in the blood). Reality is they actually > measure light absorption over time, but you can calculate an estimate > of both rate and oxygen saturation from that. > > I don't really mind simplifying that to heart-rate, but wanted to > call this out for possible discussion. They could be heart-mon. The fix is mostly around the underscore. I don't have any arguments for changing it to heart-rate, thus we can go with whatever you prefer. Best regards, Krzysztof