Re: [PATCHv2] ARM: dts: socfpga: remove underscore node names for base socfpga dtsi

[Dinh Nguyen <dinguyen@kernel.org>]

On 1/12/26 01:34, Krzysztof Kozlowski wrote:
> On 12/01/2026 05:41, Dinh Nguyen wrote:
>> The node names in a DTS file should be using a hyphen, not an underscore
>> as warned by 'dtc W=2'.
>>
>> For clock nodes, use clock-controller@address and clock-<name>. While at
>> it, fix DTS coding style to use lowercase hex for values and unit
>> addresses for these clock nodes.
>>
>> There are no functional change in this patch.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> v2: used clock-controller@address and clock-name
>>      reworded commit message
>> ---
>>   arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 128 +++++++++----------
>>   1 file changed, 64 insertions(+), 64 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> index 35be14150f41..28494aeb71b2 100644
>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> @@ -131,17 +131,17 @@ osc2: osc2 {
>>   						compatible = "fixed-clock";
>>   					};
>>   
>> -					f2s_periph_ref_clk: f2s_periph_ref_clk {
>> +					f2s_periph_ref_clk: clock-f2s-periph-ref {
>>   						#clock-cells = <0>;
>>   						compatible = "fixed-clock";
> 
> I am pretty sure this is functional change, because you just changed the
> name of the clock. At least that is the impression of above diff.
> 

Thanks for the review. I'll check it with dtx_diff and fdtdump. I just 
don't see the the clock names getting used anywhere.

Dinh