From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ben Wolsieffer <benwolsieffer@gmail.com>,
Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
Matthias Kaehlcke <mka@chromium.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Johan Hovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2
Date: Sat, 5 Aug 2023 23:30:21 +0200 [thread overview]
Message-ID: <45d25fd5-465f-347b-448b-ce171626f34e@linaro.org> (raw)
In-Reply-To: <ZMrFb7H1ynwwBSCA@Dell-Inspiron-15>
On 02/08/2023 23:06, Ben Wolsieffer wrote:
> On Sat, Jan 21, 2023 at 05:56:31PM +0000, Anand Moon wrote:
>> On Odroid c2 previously use gpio-hog to reset the usb hub,
>> switch to used on-board usb hub reset to enable the usb hub
>> and enable power to hub.
>>
...
>> + hub@1 {
>> + /* Genesys Logic GL852G USB 2.0 hub */
>> + compatible = "usb5e3,610";
>> + reg = <1>;
>> + vdd-supply = <&p5v0>;
>> + reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
>> + };
>> };
>> --
>> 2.38.1
>>
>
> Hello,
>
> This patch breaks USB support on the ODROID-C2. As soon as the
> onboard_usb_hub module is loaded, all USB devices disconnect.
> Blacklisting onboard_usb_hub makes USB work as expected.
>
> I tried to reproduce the problem by manually toggling the reset line,
> but the problem seems to be specific to this driver. When reset is
> asserted manually, the devices disconnect, but they all enumerate again
> as soon as reset is released.
>
> Also, I have been unable to make USB work again (until the next reboot)
> even after unloading onboard_usb_hub.
Wasn't this patch made exactly to fix USB support, not break it? I might
be missing something but maybe this was not tested at all?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-05 21:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230121175639.12818-1-linux.amoon@gmail.com>
2023-01-21 17:56 ` [PATCH v3 1/9] dt-bindings: usb: Add device id for Genesys Logic hub controller Anand Moon
2023-01-25 14:34 ` Greg Kroah-Hartman
2023-01-25 14:41 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 2/9] ARM: dts: amlogic: Used onboard usb hub reset on odroid c1 Anand Moon
2023-01-21 17:56 ` [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 Anand Moon
2023-08-02 21:06 ` Ben Wolsieffer
2023-08-05 21:30 ` Krzysztof Kozlowski [this message]
2023-08-06 0:05 ` Ben Wolsieffer
2023-08-06 4:03 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 5/9] vendor-prefixes: Add VIA Labs, Inc Anand Moon
2023-01-21 18:51 ` Krzysztof Kozlowski
2023-01-22 7:04 ` Anand Moon
2023-01-22 9:36 ` Krzysztof Kozlowski
2023-01-22 16:38 ` Anand Moon
2023-01-21 17:56 ` [PATCH v3 6/9] dt-bindings: usb: Add Via lab VL817 hub Anand Moon
2023-01-21 18:52 ` Krzysztof Kozlowski
2023-01-21 17:56 ` [PATCH v3 7/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c4 Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d25fd5-465f-347b-448b-ce171626f34e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=benwolsieffer@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mka@chromium.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).