From: Krzysztof Kozlowski <krzk@kernel.org>
To: Komal Bajaj <quic_kbajaj@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Melody Olvera <quic_molvera@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting
Date: Tue, 14 May 2024 15:27:14 +0200 [thread overview]
Message-ID: <45e0aee9-87d5-434f-8ffe-d3270def0f72@kernel.org> (raw)
In-Reply-To: <20240514131038.28036-1-quic_kbajaj@quicinc.com>
On 14/05/2024 15:10, Komal Bajaj wrote:
> Fixing the regulator voltages for qdu/qru1000 idp boards.
> In particular -
> - smps4 is 1.574V min and 2.04V max
> - smps5 is 1.2V min and 1.4V max
> - smps6 is 0.382V min and 1.12V max
Wait, why? This looks, at least partially, you are changing from fixed
voltage choice to full range, without clear explanation.
> - smps8 is fixed at 0.752V
>
> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs")
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-14 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 13:10 [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting Komal Bajaj
2024-05-14 13:27 ` Krzysztof Kozlowski [this message]
2024-05-16 5:52 ` Komal Bajaj
2024-05-17 8:50 ` Krzysztof Kozlowski
2024-05-20 12:19 ` Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e0aee9-87d5-434f-8ffe-d3270def0f72@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kbajaj@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).