Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Muzaffer Kadir <muzafferkadir@mainlining.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver
Date: Fri, 4 Sep 2026 11:43:46 +0200	[thread overview]
Message-ID: <45e238e2-4c02-43c2-8050-cba0862f6be0@oss.qualcomm.com> (raw)
In-Reply-To: <1c059e1a-f791-4de9-87c2-cb13405b69bb@mainlining.org>



On 02-Sep-26 18:11, Muzaffer Kadir wrote:
> Hi Konrad,

[...]

>>   must have a matching mipi_dsi0 entry in the GPIO0 PINGROUP() definition. The same consistency is required for every item in the table. The gpio function is intentionally excluded because it is inserted
>>   implicitly by the PINGROUP() macro.
> 
> Sibling SoCs like msm8917, msm8953 and
> msm8976 do leave them without any PINGROUP() too.
> I don't know what function index they map to
> and I don't want to cause bugs by wrong indexes.
> I don't know what to do with them.
> Should I remove them?

Apparently, for 8952, someone took their creative liberty
to rename function 0 (GPIO) into what looks like the
assignments on some internal devboard. All of these are
just GPIO functions (i.e. drop the other definitions,
they're totally bogus) except for:

  Function                GPIO group    Mux index
  ━━━━━━━━━━━━━━━━━━━━━━  ━━━━━━━━━━━━  ━━━━━━━━━━━
   qdss_cti_trig_out_b0         GPIO2           12
  ──────────────────────  ────────────  ───────────
   qdss_cti_trig_out_a1         GPIO3           11

Thanks for spotting this

Konrad

  reply	other threads:[~2026-09-04  9:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 11:17 [PATCH v2 0/2] Add pinctrl support for MSM8952 Muzaffer Kadir via B4 Relay
2026-08-20 11:17 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl Muzaffer Kadir via B4 Relay
2026-08-20 11:17 ` [PATCH v2 2/2] pinctrl: qcom: Add MSM8952 tlmm pinctrl driver Muzaffer Kadir via B4 Relay
2026-09-02 13:03   ` Konrad Dybcio
2026-09-02 16:11     ` Muzaffer Kadir
2026-09-04  9:43       ` Konrad Dybcio [this message]
2026-08-20 16:37 ` [PATCH v2 0/2] Add pinctrl support for MSM8952 Linus Walleij
2026-09-01 15:59   ` Bartosz Golaszewski
2026-09-02 10:32     ` Muzaffer Kadir
2026-09-02 10:34       ` Bartosz Golaszewski
2026-09-02 10:41         ` Muzaffer Kadir
2026-09-02 11:06           ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45e238e2-4c02-43c2-8050-cba0862f6be0@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muzafferkadir@mainlining.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox