From: Dmitry Osipenko <digetx@gmail.com>
To: cyndis@kapsi.fi, thierry.reding@gmail.com, jonathanh@nvidia.com,
joro@8bytes.org, will@kernel.org, robin.murphy@arm.com,
robh+dt@kernel.org, krzysztof.kozlowski@canonical.com
Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH v4 3/9] gpu: host1x: Add context device management code
Date: Sat, 12 Mar 2022 21:12:31 +0300 [thread overview]
Message-ID: <45e5f833-b492-30df-a1ed-108e05a2b465@gmail.com> (raw)
In-Reply-To: <20220301161455.4037062-4-cyndis@kapsi.fi>
01.03.2022 19:14, cyndis@kapsi.fi пишет:
> +/* host1x context devices */
> +
> +struct host1x_context {
> + struct host1x *host;
> +
> + refcount_t ref;
> + struct pid *owner;
> +
> + struct device dev;
> + u64 dma_mask;
> + u32 stream_id;
> +};
I'm still not very happy about the "context" names. For example here
it's only about the "memory context", then why not to name struct as
host1x_memory_context or host1x_memctx?
It's not good to use generic names for a special things, it hurts
readability of the code. It's important to choose good names.
next prev parent reply other threads:[~2022-03-12 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 16:14 [PATCH v4 0/9] Host1x context isolation support cyndis
2022-03-01 16:14 ` [PATCH v4 1/9] dt-bindings: host1x: Add iommu-map property cyndis
2022-03-01 18:12 ` Robin Murphy
2022-03-02 12:31 ` Mikko Perttunen
2022-03-01 16:14 ` [PATCH v4 2/9] gpu: host1x: Add context bus cyndis
2022-03-01 16:14 ` [PATCH v4 3/9] gpu: host1x: Add context device management code cyndis
2022-03-12 18:12 ` Dmitry Osipenko [this message]
2022-03-01 16:14 ` [PATCH v4 4/9] gpu: host1x: Program context stream ID on submission cyndis
2022-03-01 16:14 ` [PATCH v4 5/9] iommu/arm-smmu: Attach to host1x context device bus cyndis
2022-03-01 16:14 ` [PATCH v4 6/9] arm64: tegra: Add Host1x context stream IDs on Tegra186+ cyndis
2022-03-01 16:14 ` [PATCH v4 7/9] drm/tegra: falcon: Set DMACTX field on DMA transactions cyndis
2022-03-01 16:14 ` [PATCH v4 8/9] drm/tegra: Support context isolation cyndis
2022-03-01 16:14 ` [PATCH v4 9/9] drm/tegra: vic: Implement get_streamid_offset cyndis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e5f833-b492-30df-a1ed-108e05a2b465@gmail.com \
--to=digetx@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).