From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Manivannan Sadhasivam <mani@kernel.org>,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 03/12] firmware: qcom_scm: Introduce PAS context initialization and destroy helper
Date: Tue, 7 Oct 2025 23:16:28 +0100 [thread overview]
Message-ID: <45eb9c5b-bc8e-4866-bbaf-5afaed9fda21@linaro.org> (raw)
In-Reply-To: <qqjynnzjhpe6elglh3xb4ghbtesfkr4ssxyq5flhcy7a5jp6ym@3viy7jyesamq>
On 07/10/2025 22:23, Manivannan Sadhasivam wrote:
>> +void qcom_scm_pas_context_destroy(struct qcom_scm_pas_context *ctx)
>> +{
>> + kfree(ctx->metadata);
>> + ctx->metadata = NULL;
>> + ctx->dev = NULL;
>> + ctx->pas_id = 0;
>> + ctx->mem_phys = 0;
>> + ctx->mem_size = 0;
> Why do you need to zero initialize these fields before freeing? Are they
> carrying any sensitive data that warrants zero initialization?
Mukesh, have to say I don't think adding my RB to this patch is really
warranted.
I gave review feedback that the above looked odd.
https://lore.kernel.org/linux-arm-msm/9139706a-708c-4be6-a994-120cce0cd0e6@linaro.org
Could you please drop my RB here, and fix the above in your next version.
Also please add me to the cc list for the whole series.
---
bod
next prev parent reply other threads:[~2025-10-07 22:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 16:48 [PATCH v4 00/12] Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2 Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 01/12] dt-bindings: remoteproc: qcom,pas: Add iommus property Mukesh Ojha
2025-10-08 8:09 ` Krzysztof Kozlowski
2025-10-08 11:57 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 02/12] firmware: qcom_scm: Rename peripheral as pas_id Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 03/12] firmware: qcom_scm: Introduce PAS context initialization and destroy helper Mukesh Ojha
2025-10-07 21:23 ` Manivannan Sadhasivam
2025-10-07 22:16 ` Bryan O'Donoghue [this message]
2025-10-08 7:51 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 04/12] soc: qcom: mdtloader: Add PAS context aware qcom_mdt_pas_load() function Mukesh Ojha
2025-10-07 21:29 ` Manivannan Sadhasivam
2025-10-08 7:35 ` Mukesh Ojha
2025-10-10 6:21 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 05/12] remoteproc: pas: Replace metadata context with PAS context structure Mukesh Ojha
2025-10-07 21:34 ` Manivannan Sadhasivam
2025-10-08 7:37 ` Mukesh Ojha
2025-10-10 6:24 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 06/12] firmware: qcom_scm: Add a prep version of auth_and_reset function Mukesh Ojha
2025-10-07 21:37 ` Manivannan Sadhasivam
2025-10-08 7:35 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 07/12] firmware: qcom_scm: Simplify qcom_scm_pas_init_image() Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 08/12] firmware: qcom_scm: Add SHM bridge handling for PAS when running without QHEE Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 09/12] firmware: qcom_scm: Add qcom_scm_pas_get_rsc_table() to get resource table Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 10/12] remoteproc: pas: Extend parse_fw callback to fetch resources via SMC call Mukesh Ojha
2025-10-07 21:48 ` Manivannan Sadhasivam
2025-10-08 7:33 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 11/12] remoteproc: qcom: pas: Enable Secure PAS support with IOMMU managed by Linux Mukesh Ojha
2025-10-07 21:52 ` Manivannan Sadhasivam
2025-10-08 4:58 ` Mukesh Ojha
2025-10-08 9:19 ` Konrad Dybcio
2025-10-08 12:00 ` Mukesh Ojha
2025-10-07 16:48 ` [PATCH v4 12/12] arm64: dts: qcom: Add EL2 overlay for Lemans Mukesh Ojha
2025-10-07 21:55 ` Manivannan Sadhasivam
2025-10-08 7:32 ` Mukesh Ojha
2025-10-08 10:13 ` Konrad Dybcio
2025-10-08 11:56 ` Mukesh Ojha
2025-10-10 6:27 ` Mukesh Ojha
2025-10-07 21:56 ` [PATCH v4 00/12] Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2 Manivannan Sadhasivam
2025-10-10 10:08 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45eb9c5b-bc8e-4866-bbaf-5afaed9fda21@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).