From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7ACBC433C1 for ; Fri, 26 Mar 2021 17:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BE4F61A24 for ; Fri, 26 Mar 2021 17:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbhCZRwo (ORCPT ); Fri, 26 Mar 2021 13:52:44 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:60891 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbhCZRwU (ORCPT ); Fri, 26 Mar 2021 13:52:20 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 7E5CE5803E0; Fri, 26 Mar 2021 13:52:17 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute3.internal (MEProxy); Fri, 26 Mar 2021 13:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm1; bh=8kXwPtHhldbtwjNjOopwUJ4yeuP+ UupShvi+BRfDlsU=; b=kkWAJEnK7AL7xBL0aeNOCJjZAgkNurezljLLaszKkIkx V4eNarYodtl3szZ/3/55p9PRCd4uqljo4oDOhD2G3kp8O86deVVDTNH+cNqZtgFy EnSrpTG6gnEcW3BBjF6Nt+sPS8XHhyvwrYSfklOB+vW2ztwn4EXGaQ0dAwBgsqBI FD6TnH5oNMrhiqHhegV/JP5NzH+DRx/4sf+pf+C0qADSlSc+8zl9gZ6xw+sNWIJy bKHjbSxfZLrPXSd5k/RP9xZvK25rXvK/YAuYBnjRh5ON807srOKOGICtMLDCIIg2 oarIZEB9fx4ZOv9TNYZEE6njGrHcjblgGOL2cYkpnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8kXwPt HhldbtwjNjOopwUJ4yeuP+UupShvi+BRfDlsU=; b=M1f3i3TpnYArNC62R6uBrG blLIAjBY8OCsvChA96rOpEyqSBMP8UK9cN8jP4YDXTqDhpJ2DF89sds2txc3s0re lYFK02qispO0elErLVdusUc+qMvaD4LBZsjATmVKqU6WRUaPRb+akKdSdUDmfoTG rkbk/iQzy9X4QBgA0NvrUGGE2Qv2nsDKH+1HJJ2mY2CIAMjX2skcqQucQ+Wr8TLA eVZWAHoB7rB9ycAZEGr0uqs2KFxCxd+RdMHZw0OWRW3YWSxUDnZFebg1eXhbb/80 7glSyB3atL1+a7aSUBUHtvh4ypM7IfIKBLRKkP0kV3witNlHJPWF1uLaVC5c5kfg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepgfeigeeiffeuhfettdejgfetjeetfeelfefgfefgvddvtdfghfffudeh vdefkeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id E184E51C005F; Fri, 26 Mar 2021 13:52:15 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: <45faaadd-eda7-464f-96ff-7324f566669e@www.fastmail.com> In-Reply-To: References: <20210320151903.60759-1-sven@svenpeter.dev> <20210323205346.GA1283560@robh.at.kernel.org> <43685c67-6d9c-4e72-b320-0462c2273bf0@www.fastmail.com> <9f06872d-f0ec-43c3-9b53-d144337100b3@www.fastmail.com> Date: Fri, 26 Mar 2021 18:51:55 +0100 From: "Sven Peter" To: "Robin Murphy" , "Mark Kettenis" , "Arnd Bergmann" Cc: "Rob Herring" , iommu@lists.linux-foundation.org, joro@8bytes.org, "Will Deacon" , "Hector Martin" , "Marc Zyngier" , mohamed.mediouni@caramail.com, stan@corellium.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 0/3] Apple M1 DART IOMMU driver Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Mar 26, 2021, at 18:34, Robin Murphy wrote: > On 2021-03-26 17:26, Mark Kettenis wrote: > > > > Anyway, from my viewpoint having the information about the IOVA > > address space sit on the devices makes little sense. This information > > is needed by the DART driver, and there is no direct cnnection from > > the DART to the individual devices in the devicetree. The "iommus" > > property makes a connection in the opposite direction. > > What still seems unclear is whether these addressing limitations are a > property of the DART input interface, the device output interface, or > the interconnect between them. Although the observable end result > appears more or less the same either way, they are conceptually > different things which we have different abstractions to deal with. > > Robin. > I'm not really sure if there is any way for us to figure out where these limitation comes from though. I've done some more experiments and looked at all DART nodes in Apple's Device Tree though. It seems that most (if not all) masters only connect 32 address lines even though the iommu can handle a much larger address space. I'll therefore remove the code to handle the full space for v2 since it's essentially dead code that can't be tested anyway. There are some exceptions though: There are the PCIe DARTs which have a different limitation which could be encoded as 'dma-ranges' in the pci bus node: name base size dart-apcie1: 00100000 3fe00000 dart-apcie2: 00100000 3fe00000 dart-apcie0: 00100000 3fe00000 dart-apciec0: 00004000 7fffc000 dart-apciec1: 80000000 7fffc000 Then there are also these display controller DARTs. If we wanted to use dma-ranges we could just put them in a single sub bus: name base size dart-disp0: 00000000 fc000000 dart-dcp: 00000000 fc000000 dart-dispext0: 00000000 fc000000 dart-dcpext: 00000000 fc000000 And finally we have these strange ones which might eventually each require another awkward sub-bus if we want to stick to the dma-ranges property. name base size dart-aop: 00030000 ffffffff ("always-on processor") dart-pmp: 00000000 bff00000 (no idea yet) dart-sio: 0021c000 fbde4000 (at least their Secure Enclave/TPM co-processor) dart-ane: 00000000 e0000000 ("Neural Engine", their ML accelerator) For all we know these limitations could even arise for different reasons. (the secure enclave one looks like it might be imposed by the code running on there). Not really sure to proceed from here. I'll give the dma-ranges options a try for v2 and see how that one works out but that's not going to help us understand *why* these limitations exist. At least I won't have to change much code if we agree on a different abstraction :) The important ones for now are probably the USB and the PCIe ones. We'll need the display ones after that and can probably ignore the strange ones for quite a while. Best, Sven