Re: [PATCH v2 09/10] ARM: dts: sun8i: add DTSI file for V853

Rob Herring
2025-02-11T21:08:15Z

On Thu, Feb 06, 2025 at 04:19:58PM +0000, Andre Przywara wrote:
> On Wed, 5 Feb 2025 13:52:24 +0100
> Andras Szemzo <szemzo.andras@gmail.com> wrote:
>
> Hi,
>
> > V853/V851 is a new SoC by Allwinner. Add a basic dtsi file for it.
> >
> > Signed-off-by: Andras Szemzo <szemzo.andras@gmail.com>
> > ---
> > arch/arm/boot/dts/allwinner/sun8i-v853.dtsi | 656 ++++++++++++++++++++
> > 1 file changed, 656 insertions(+)
> > create mode 100644 arch/arm/boot/dts/allwinner/sun8i-v853.dtsi
> >
> > diff --git a/arch/arm/boot/dts/allwinner/sun8i-v853.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v853.dtsi
> > new file mode 100644
> > index 000000000000..8b82b8783127
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/allwinner/sun8i-v853.dtsi
> > @@ -0,0 +1,656 @@
> > +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> > +// Copyright (C) 2024 Andras Szemzo <szemzo.andras@gmail.com>
> > +
> > +#include <dt-bindings/clock/sun6i-rtc.h>
> > +#include <dt-bindings/clock/allwinner,sun8i-v853-r-ccu.h>
> > +#include <dt-bindings/reset/allwinner,sun8i-v853-r-ccu.h>
> > +#include <dt-bindings/clock/allwinner,sun8i-v853-ccu.h>
> > +#include <dt-bindings/reset/allwinner,sun8i-v853-ccu.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/allwinner,sun8i-v853-ppu.h>
> > +
> > +/ {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + dcxo: dcxo-clk {
>
> What's people's opinion about the node name? Traditionally we call this
> "osc24M", in all the other SoCs except D1 and A100. So is this the new
> black?

That's documented (but not enforced) in fixed-clock.yaml now. It's
"clock-<freq-in-hz>".

Rob