Re: [PATCH 5/8] arm64: dts: rockchip: Fix bluetooth properties on rk3566 box demo

["Heiko Stübner" <heiko@sntech.de>]

Hi Diederik,

Am Montag, 7. Oktober 2024, 17:27:12 CEST schrieb Diederik de Haas:
> On Mon Sep 30, 2024 at 11:01 PM CEST, Heiko Stuebner wrote:
> > The expected clock-name is different (ext_clock -> extclk) and the wakeup
> 
> According to "brcm,bluetooth.yaml", 'extclk' is deprecated in favor of
> 'txco', so it seems better to use that?
> Same would be true for Rock960 boards (patch 6 of this series).

thanks for that catch. I mainly stumbled upon the "_" underscore, found the
clockname without but didn't take into account that there was a deprecated
flag set in the binding :-)


> > gpio properties are named differently when changing from vendor-tree to
> > mainline. So fix those to match the binding.
> >
> > Fixes: 2e0537b16b25 ("arm64: dts: rockchip: Add dts for rockchip rk3566 box demo board")
> > Cc: Andy Yan <andyshrk@163.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > index 0c18406e4c59..dd6fe964d618 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts
> > @@ -449,9 +449,9 @@ &uart1 {
> >  	bluetooth {
> >  		compatible = "brcm,bcm43438-bt";
> >  		clocks = <&pmucru CLK_RTC_32K>;
> > -		clock-names = "ext_clock";
> > -		device-wake-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > -		host-wake-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> > +		clock-names = "extclk";
> > +		device-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
> > +		host-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
> >  		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&bt_host_wake_l &bt_wake_l &bt_enable_h>;
> 
>