From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alex Soo <yuklin.soo@starfivetech.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Yangtao Li <frank.li@vivo.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: sdhci-cadence6: add DT bindings documentation
Date: Thu, 4 Jan 2024 10:28:56 +0100 [thread overview]
Message-ID: <46155b58-f952-42d5-b607-8a4e83a25ac9@linaro.org> (raw)
In-Reply-To: <20231228065322.1176351-2-yuklin.soo@starfivetech.com>
On 28/12/2023 07:53, Alex Soo wrote:
> Add DT bindings documentation for Cadence SD/eMMC host controller
> (Version 6) driver.
>
> Signed-off-by: Alex Soo <yuklin.soo@starfivetech.com>
A nit, subject: drop second/last, redundant "DT bindings documentation".
The "dt-bindings" prefix is already stating that these are bindings.
Basically your subject is pure redundancy.
> ---
> .../devicetree/bindings/mmc/cdns,sd6hci.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
> new file mode 100644
> index 000000000000..97e28d720c7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
There were several other patches adding this, so please consolidate the
effort. You just duplicated a lot of code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 6:53 [PATCH 0/3] Add driver for Cadence SD6HC SD/eMMC controller Alex Soo
2023-12-28 6:53 ` [PATCH 1/3] dt-bindings: mmc: sdhci-cadence6: add DT bindings documentation Alex Soo
2024-01-04 9:28 ` Krzysztof Kozlowski [this message]
2023-12-28 6:53 ` [PATCH 2/3] mmc: sdhci-cadence6: add Cadence SD6HC support Alex Soo
2024-01-04 9:29 ` Krzysztof Kozlowski
2023-12-28 6:53 ` [PATCH 3/3] riscv: dts: starfive: jh8100: Add SD/eMMC device tree nodes Alex Soo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46155b58-f952-42d5-b607-8a4e83a25ac9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@vivo.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yuklin.soo@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).