devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants
Date: Sun, 18 Aug 2024 19:44:22 +0200	[thread overview]
Message-ID: <4615f52b-4e4c-4fe4-bfef-a66e196410d7@linaro.org> (raw)
In-Reply-To: <20240818174137.GC29465@pendragon.ideasonboard.com>

On 18/08/2024 19:41, Laurent Pinchart wrote:
> Hi Krzysztof,
> 
> Thank you for the patch.
> 
> On Sun, Aug 18, 2024 at 07:30:02PM +0200, Krzysztof Kozlowski wrote:
>> Each variable-length property like interrupts or resets must have fixed
>> constraints on number of items for given variant in binding.  The
>> clauses in "if:then:" block should define both limits: upper and lower.
> 
> I thought that, when only one of minItems or maxItems was specified, the
> other automatically defaulted to the same value. I'm pretty sure I
> recall Rob asking me to drop one of the two in some bindings. Has the
> rule changes ? Is it documented somewhere ?

New dtschema changed it and, even if previous behavior is restored, the
size in if:then: always had to be constrained. You could have skipped
one side of limit if it was equal to outer/top-level limit, e.g:

properties:
  clocks:
    minItems: 1
    maxItems: 2


if:then:properties:
  clocks:
    minItems: 2


Best regards,
Krzysztof


  reply	other threads:[~2024-08-18 17:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-18 17:30 [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants Krzysztof Kozlowski
2024-08-18 17:30 ` [PATCH 2/2] dt-bindings: display: renesas,du: add top-level constraints Krzysztof Kozlowski
2024-08-18 17:46   ` Laurent Pinchart
2024-08-19 17:11   ` Conor Dooley
2024-08-18 17:41 ` [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants Laurent Pinchart
2024-08-18 17:44   ` Krzysztof Kozlowski [this message]
2024-08-18 17:51     ` Laurent Pinchart
2024-08-18 18:48       ` Krzysztof Kozlowski
2024-08-28 12:45         ` Laurent Pinchart
2024-08-28 12:52           ` Krzysztof Kozlowski
2024-08-28 13:29             ` Laurent Pinchart
2024-08-19 17:12 ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4615f52b-4e4c-4fe4-bfef-a66e196410d7@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=magnus.damm@gmail.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).