From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Grégoire Layet" <gregoire.layet@9elements.com>,
joel@jms.id.au, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, corey@minyard.net,
devicetree@vger.kernel.org
Cc: openipmi-developer@lists.sourceforge.net,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ipmi: kcs_bmc_aspeed: g6: Add KCS Channel 4 over PCIe
Date: Thu, 23 Jul 2026 13:44:00 +0930 [thread overview]
Message-ID: <4622688c45db99274e6862c15fe665268c9efb10.camel@codeconstruct.com.au> (raw)
In-Reply-To: <a283420c1fb6a99df5331e078c7f15b3c97822c6.1784732161.git.gregoire.layet@9elements.com>
On Wed, 2026-07-22 at 15:11 +0000, Grégoire Layet wrote:
> Created a 5th KCS channel to match against the KCS 4 over PCIe addresses.
>
> The ASPEED AST2600 has a PCIe to LPC controller. It includes a KCS
> interface on channel 4. This is a fully KCS-compatible interface
> that is exposed over PCIe.
>
> The 5th channel created is only valid on the AST2600.
> This cannot be used for AST2400 and AST2500 chips, as they don't have LPC
> over PCIE.
>
> Signed-off-by: Grégoire Layet <gregoire.layet@9elements.com>
>
...
> @@ -373,6 +395,9 @@ static void aspeed_kcs_enable_channel(struct kcs_bmc_device *kcs_bmc, bool enabl
> case 4:
> regmap_update_bits(priv->map, LPC_HICRB, LPC_HICRB_LPC4E, enable * LPC_HICRB_LPC4E);
> return;
> + case 5:
> + regmap_update_bits(priv->map, PCIE_LPC_HICRB, LPC_HICRB_LPC4E, enable * LPC_HICRB_LPC4E);
This one exceeds 100 chars. checkpatch can help catch these types of
issues.
Otherwise this seems okay.
Andrew
next prev parent reply other threads:[~2026-07-23 4:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 15:11 [PATCH v2 0/2] soc: aspeed: ipmi: add KCS Channel 4 over PCIe Grégoire Layet
2026-07-22 15:11 ` [PATCH v2 1/2] ipmi: kcs_bmc_aspeed: g6: Add " Grégoire Layet
2026-07-22 15:22 ` sashiko-bot
2026-07-23 4:14 ` Andrew Jeffery [this message]
2026-07-22 15:11 ` [PATCH v2 2/2] ARM: dts: aspeed-g6: add pcie-kcs4 Grégoire Layet
2026-07-22 15:24 ` sashiko-bot
2026-07-23 4:13 ` Andrew Jeffery
2026-07-23 7:56 ` Grégoire Layet
2026-07-23 3:48 ` [PATCH v2 0/2] soc: aspeed: ipmi: add KCS Channel 4 over PCIe Jammy Huang
2026-07-23 6:12 ` YC Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4622688c45db99274e6862c15fe665268c9efb10.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=corey@minyard.net \
--cc=devicetree@vger.kernel.org \
--cc=gregoire.layet@9elements.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox