Re: [PATCH v11 7/7] media: qcom: camss: Drop legacy PHY descriptions from x1e

Loic Poulain
2026-04-07T13:59:21Z

On Thu, Mar 26, 2026 at 2:29 AM Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> x1e is the first CAMSS SoC to use the new PHY interface. Drop the redundant
> legacy CSIPHY descriptions.
>
> Reviewed-by: Christopher Obbard <christopher.obbard@linaro.org>
> Tested-by: Christopher Obbard <christopher.obbard@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>

> ---
> drivers/media/platform/qcom/camss/camss.c | 37 -------------------------------
> 1 file changed, 37 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 224b5472d7771..3b092560b5df5 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -3896,15 +3896,6 @@ static const struct resources_icc icc_res_sa8775p[] = {
> static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
> /* CSIPHY0 */
> {
> - .regulators = {
> - { .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> - { .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> - },
> - .clock = { "csiphy0", "csiphy0_timer" },
> - .clock_rate = { { 300000000, 400000000, 480000000 },
> - { 266666667, 400000000 } },
> - .reg = { "csiphy0" },
> - .interrupt = { "csiphy0" },
> .csiphy = {
> .id = 0,
> .hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3913,15 +3904,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
> },
> /* CSIPHY1 */
> {
> - .regulators = {
> - { .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> - { .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> - },
> - .clock = { "csiphy1", "csiphy1_timer" },
> - .clock_rate = { { 300000000, 400000000, 480000000 },
> - { 266666667, 400000000 } },
> - .reg = { "csiphy1" },
> - .interrupt = { "csiphy1" },
> .csiphy = {
> .id = 1,
> .hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3930,15 +3912,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
> },
> /* CSIPHY2 */
> {
> - .regulators = {
> - { .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> - { .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> - },
> - .clock = { "csiphy2", "csiphy2_timer" },
> - .clock_rate = { { 300000000, 400000000, 480000000 },
> - { 266666667, 400000000 } },
> - .reg = { "csiphy2" },
> - .interrupt = { "csiphy2" },
> .csiphy = {
> .id = 2,
> .hw_ops = &csiphy_ops_3ph_1_0,
> @@ -3947,15 +3920,6 @@ static const struct camss_subdev_resources csiphy_res_x1e80100[] = {
> },
> /* CSIPHY4 */
> {
> - .regulators = {
> - { .supply = "vdd-csiphy-0p8", .init_load_uA = 105000 },
> - { .supply = "vdd-csiphy-1p2", .init_load_uA = 58900 }
> - },
> - .clock = { "csiphy4", "csiphy4_timer" },
> - .clock_rate = { { 300000000, 400000000, 480000000 },
> - { 266666667, 400000000 } },
> - .reg = { "csiphy4" },
> - .interrupt = { "csiphy4" },
> .csiphy = {
> .id = 4,
> .hw_ops = &csiphy_ops_3ph_1_0,
> @@ -5365,7 +5329,6 @@ static const struct camss_resources sm8650_resources = {
> static const struct camss_resources x1e80100_resources = {
> .version = CAMSS_X1E80100,
> .pd_name = "top",
> - .legacy_phy = true,
> .csiphy_res = csiphy_res_x1e80100,
> .csid_res = csid_res_x1e80100,
> .vfe_res = vfe_res_x1e80100,
>
> --
> 2.52.0
>
>