From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH 03/25] arm: bcm: dts: Remove leading 0x and 0s from bindings notation Date: Fri, 15 Dec 2017 14:16:58 +0100 Message-ID: <4642ee3f-ee51-91ed-5e34-883c1906dfd7@i2se.com> References: <20171215124628.30029-1-malat@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171215124628.30029-1-malat@debian.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mathieu Malaterre , Rob Herring , Florian Fainelli Cc: Mark Rutland , devicetree@vger.kernel.org, Scott Branden , Jon Mason , Ray Jui , linux-kernel@vger.kernel.org, Russell King , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org [Add Eric] Am 15.12.2017 um 13:46 schrieb Mathieu Malaterre: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre > --- > arch/arm/boot/dts/bcm11351.dtsi | 2 +- > arch/arm/boot/dts/bcm21664.dtsi | 2 +- > arch/arm/boot/dts/bcm283x.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > Acked-by: Stefan Wahren only for bcm283x.dtsi @Florian: I assume this should go through your tree directly.