From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07266305E19; Fri, 10 Apr 2026 08:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811291; cv=none; b=IgdkjeQhTyY/0LgfdifLPLRZJlK+thSL5LI1kB6RIydSg7KqUECPq6tT0EEKCa5t68QR2135UVAWSEgctayTXWFARBTmBbf9fK3X+JGfV86wn5iPkMVfXZJrjJPtVz6QxA6GIQ5QaGbStTLsdmE0p4IGvCqCuheCG4ZAQ7RnNAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775811291; c=relaxed/simple; bh=MMtxsrkqQ9E3tHrJoFVat5snTEJSC/OwEr/bx1yLdWQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gu/nDsQjpCDyC75ImdV37FTzXVJInqjU8RIAMlHVORIf0n4pIquBSAgR/LdxX/iwlv0TrmuxpGiZaX6jFdBszPLYc+ICmiZvoxOBJnF1EWWJJgujH60oi5/3+gAIXEGPmpLcEQ0WMTeb50uj/Ljqcx87D3pxh2p0aw1dG1HVBV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fskC/i67; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fskC/i67" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC139C19421; Fri, 10 Apr 2026 08:54:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775811290; bh=MMtxsrkqQ9E3tHrJoFVat5snTEJSC/OwEr/bx1yLdWQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fskC/i67qmRQ240SMOKDpLdx7nv/QdQlfsZaDq5IWiDil47TZCqU0tV5lJgrm2cv/ z4ijrToRgFNQR8rIUBZP9hakdcq/Vt47jil7dMqByjYhO31ovRHy+1LtIg2mbMvjNH aCSJyV5iWl6ak4tArXAPDTUWAA3b6enEBtAXB8AuQ7JpU20Ebr2tiP6/d4jGmc6jnJ tIQaJOttyB9FEg5vFnnBzkhKBy1FwAA8tZlMEls5pgHUgofTz8PeZ1tjx2CTx+6UdF ja6AGUEYhHqkKXkKJgLe2HZzB76SpU3wB+2SMqFhSSZDg34E2BA33UW5kmLRtETg8B hNUp8hnVq133g== Message-ID: <464eec5f-85c6-45ef-ac5f-a6b54ddc1315@kernel.org> Date: Fri, 10 Apr 2026 10:54:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: ipq5210: add the bootph-all property To: Kathiravan Thirumoorthy , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260409-add_bootph-v1-1-cb2b5093f7d7@oss.qualcomm.com> <8fe36a5e-1ebc-4c5f-9c3b-3c50ebd2274e@kernel.org> <9d99f3ad-e2ec-4a17-ab07-3d379dc28d55@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <9d99f3ad-e2ec-4a17-ab07-3d379dc28d55@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2026 10:41, Kathiravan Thirumoorthy wrote: > > On 4/9/2026 3:33 PM, Krzysztof Kozlowski wrote: >> On 09/04/2026 11:28, Kathiravan Thirumoorthy wrote: >>> Add the bootph-all property to the nodes which are utilized by the >>> bootloaders. >> Uh oh, so it started for qcom too? I really don't like how these bootph >> properties spread all over, so please provide arguments - which pure >> upstream bootloaders exactly and why exactly these nodes. > > This is needed for U-Boot SPL for IPQ5210 [1]. Mention U-Boot SPL in commit msg and add Link for commit msg (or changelog if other prefers that). > > [1] - > https://lore.kernel.org/u-boot/20260408091136.2794546-1-varadarajan.narayanan@oss.qualcomm.com/ > >>> Signed-off-by: Kathiravan Thirumoorthy >>> --- >>> arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts | 5 +++++ >>> arch/arm64/boot/dts/qcom/ipq5210.dtsi | 10 ++++++++++ >>> 2 files changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts >>> index 941f866ecfe9..56dbc506da78 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts >>> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts >>> @@ -17,6 +17,7 @@ aliases { >>> >>> chosen { >>> stdout-path = "serial0"; >>> + bootph-all; >> Since when do we add bootph-all to chosen? Which broken bootloader >> ignores chosen? >> >> This really makes me wonder that you do all this for some downstream forks. > > U-Boot doesn't need it, but U-Boot SPL needs it. I understand, but let me rephrase my question better. Which bootloader build process ignores chosen when preparing final DTB for the target? Maybe that build process needs to be fixed. > >>> }; >>> }; >>> >>> @@ -41,6 +42,7 @@ qup_uart1_default_state: qup-uart1-default-state { >>> function = "qup_se1"; >>> drive-strength = <6>; >>> bias-pull-down; >>> + bootph-all; >>> }; >> And that's a pin, not a device. What is the point of marking it? The >> device needing this pin will have phandle which must pull the node. > > This is because of the fdtgrep tool's limitations, which removes these > nodes in the final DTB if this property is not present. fdtgrep should be fixed. I see no point in marking obvious dependencies. Best regards, Krzysztof