From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/5] arm64: dts: rockchip: Add rk3399 vop and display-subsystem Date: Fri, 14 Jul 2017 01:34:53 +0200 Message-ID: <4655605.dLm3uFpe8F@phil> References: <1499875435-23944-1-git-send-email-jacob-chen@iotwrt.com> <1499875435-23944-2-git-send-email-jacob-chen@iotwrt.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1499875435-23944-2-git-send-email-jacob-chen-fyOeoxGR3m/QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jacob Chen Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org, Yakir Yang List-Id: devicetree@vger.kernel.org Hi Jacob, Am Donnerstag, 13. Juli 2017, 00:03:51 CEST schrieb Jacob Chen: > Add devicetree nodes for rk3399 VOP (Video Output Processors), and the > top level display-subsystem root node. > > Later patches add endpoints (eDP, HDMI, MIPI, etc) that attach to the > VOPs' output ports. > > Signed-off-by: Mark Yao > Signed-off-by: Yakir Yang > Signed-off-by: Caesar Wang > Signed-off-by: Jacob Chen > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 65 ++++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index e795135..300e500 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1455,6 +1455,71 @@ > status = "disabled"; > }; > > + vopl: vop@ff8f0000 { > + compatible = "rockchip,rk3399-vop-lit"; > + reg = <0x0 0xff8f0000 0x0 0x1ffc>, <0x0 0xff8f2000 0x0 0x400>; What is this second memory region doing? It looks like this is the meant to cover VOP_GAMMA_LUT_ADDR, but can't you just map the whole area? ChromeOS seems to be doing fine using the whole area as <0x0 0xff8f0000 0x0 0x3efc> and I've also not seen any code changes actually mapping/using this second area. > + interrupts = ; > + clocks = <&cru ACLK_VOP1>, <&cru DCLK_VOP1>, <&cru HCLK_VOP1>, <&cru DCLK_VOP1_DIV>; > + clock-names = "aclk_vop", "dclk_vop", "hclk_vop", "dclk_source"; While I know that this is based on my idea on handling the hdmi pll-rate requirements, I haven't found the matching code- and dt-binding-changes posted to a list yet. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html