From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B50F325CC96 for ; Fri, 28 Feb 2025 10:21:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740738094; cv=none; b=FidgBJaTcXlQJNCKo2W1AtWCfzAtgmpVEmY88+VNIM4xpxTRXz8cS5qvuIqHaD/Bus8zjFgJeq1SUjPUtAZK2T9irrG2m9EX97w9yVtNfsK8UJTd1tTIVFIFxArDlTNab03YbNhfYRnTJgTkQofPjRxSEKiHkflXSQSbvhpwYSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740738094; c=relaxed/simple; bh=YmZwe21JQSoM02pQA3VHIdehiaTkyyio0c9TQ49QU6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hgNpz3YZrRgfs7Xi4CE3bIgAww5GNowkEp4Z6yI/2URgoLrN0I38FGa+sD6GUcLoFIASyhu0umjNTEKFAcsKZ0lYvmKJm+AVdwW9GDv3iQhRsPkQvm/2QByx6iemgOsMRRQ/X0LbxG5wqZ8XXdevhcahAyxY/gGfzlRPsgxMJqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=ZupeaTG4; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=euyd0mwT reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="ZupeaTG4"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="euyd0mwT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1740738090; x=1772274090; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/QhhlC9uU19V9J88cHdgykY4awBetTHBnxL1KmQ0R5Y=; b=ZupeaTG4OeHu8EVbdmbDNaHBOIH7Hce+14R68dj00LJeSrjbif6gxNEL tXmuROx00Mrjr0MdIi/z8P5od3Xclan1IE3n0CkZP9zryyIU773Ce+mKB eGIftYxkqzMe/Bw/Y67/vj71uASY34qd3sXDKVRBIvQg+asTrVswon9Oi 1MlKk14oZSY9NcTXlFlUkBmbIu4ljLG0quRe1sQ1ZZKqw/pTPUmBe8qIr S5bwCCtUvZKwZfsRKTfjxBSf6KobtXZJoXcw4DhfYZMq9Uq7ghNL5rPfT olsSJW5p8qhrJLo8fkxBGwA8RarH1I5PjPulfc5Cq3nn9PpcJ78fmYzcC A==; X-CSE-ConnectionGUID: iRr4JPuoTGmOPgXGpB/sWw== X-CSE-MsgGUID: /XNPAa7+SRufdkOdkliC7A== X-IronPort-AV: E=Sophos;i="6.13,322,1732575600"; d="scan'208";a="42171468" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 28 Feb 2025 11:21:28 +0100 X-CheckPoint: {67C18E28-2-2895743E-CD1E7AB7} X-MAIL-CPID: EA36C0BEDADF546230EE4332BB39D6D7_4 X-Control-Analysis: str=0001.0A002112.67C18E28.0040,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9B9E8168CC3; Fri, 28 Feb 2025 11:21:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1740738083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/QhhlC9uU19V9J88cHdgykY4awBetTHBnxL1KmQ0R5Y=; b=euyd0mwTUQC8rghcISeYrvLp+e7Pnfs8TQ7r5JTkCNqvnyw0ANilA7BZoghCHFXpeopLTR momj1MWbV7jthBuGgRyi9sHlWesBOHTym4XU7zGDW8AhMsqmiwVkixCQr77vwqBYddE9Zh pKpz0kQ7taADcCxGzvDNuHJg3jMaX4QSuomEjGTA14ylL1UpUXTM1GvdR4iAflpUoIKM7v 3Ig4gUAI+gPhdMKPmSfmBLhZ7AHPIDRaGEnNt55UEgLkNkEXvz1efsvQke52dxzSNKE4Rd k/61BxrVWSQCvVWsonKTLQtICKW/M3d2h3+ilzVX/Sa1yXYY7ecJX5rG/jeXLQ== From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: Marek Vasut , Boris Brezillon , Conor Dooley , David Airlie , Fabio Estevam , Krzysztof Kozlowski , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Pengutronix Kernel Team , Philipp Zabel , Rob Herring , Sascha Hauer , Sebastian Reichel , Shawn Guo , Simona Vetter , Steven Price , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, Marek Vasut Subject: Re: [PATCH 8/9] drm/panthor: Add i.MX95 support Date: Fri, 28 Feb 2025 11:21:21 +0100 Message-ID: <4658624.cEBGB3zze1@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20250227170012.124768-9-marex@denx.de> References: <20250227170012.124768-1-marex@denx.de> <20250227170012.124768-9-marex@denx.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi Marek, Am Donnerstag, 27. Februar 2025, 17:58:08 CET schrieb Marek Vasut: > The instance of the GPU populated in Freescale i.MX95 is the > Mali G310, add support for this variant. >=20 > Signed-off-by: Marek Vasut > --- > Cc: Boris Brezillon > Cc: Conor Dooley > Cc: David Airlie > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Liviu Dudau > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Pengutronix Kernel Team > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Sebastian Reichel > Cc: Shawn Guo > Cc: Simona Vetter > Cc: Steven Price > Cc: Thomas Zimmermann > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/panthor/panthor_drv.c | 1 + > drivers/gpu/drm/panthor/panthor_gpu.c | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pant= hor/panthor_drv.c > index 06fe46e320738..2504a456d45c4 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -1591,6 +1591,7 @@ static struct attribute *panthor_attrs[] =3D { > ATTRIBUTE_GROUPS(panthor); > =20 > static const struct of_device_id dt_match[] =3D { > + { .compatible =3D "fsl,imx95-mali" }, /* G310 */ > { .compatible =3D "rockchip,rk3588-mali" }, > { .compatible =3D "arm,mali-valhall-csf" }, > {} > diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/pant= hor/panthor_gpu.c > index 0f07ef7d9aea7..2371ab8e50627 100644 > --- a/drivers/gpu/drm/panthor/panthor_gpu.c > +++ b/drivers/gpu/drm/panthor/panthor_gpu.c > @@ -67,6 +67,7 @@ struct panthor_model { > } > =20 > static const struct panthor_model gpu_models[] =3D { > + GPU_MODEL(g310, 0, 0), /* NXP i.MX95 */ Are you sure about 0, 0? With this I get > [drm] mali-unknown id 0xac74 major 0x0 minor 0x0 status 0x1 Using GPU_MODEL(g310, 10, 4) I get: > [drm] mali-g310 id 0xac74 major 0x0 minor 0x0 status 0x1 Note the output is GPU_VER_MAJOR() but this table is for GPU_ARCH_MAJOR() (and the corresponding minor). Best regards, Alexander > GPU_MODEL(g610, 10, 7), > {}, > }; >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/