Re: [PATCH] arm64: dts: rockchip: Enable TYPE-C PD for ROC-RK3399-PC

[Heiko Stuebner <heiko@sntech.de>]

Am Dienstag, 25. Juli 2023, 10:02:21 CEST schrieb Christopher Obbard:
> Hi Da, Jagan,
> 
> On Tue, 2023-07-25 at 03:39 -0400, Da Xue wrote:
> > On Mon, Jul 24, 2023 at 9:55 AM Christopher Obbard
> > <chris.obbard@collabora.com> wrote:
> > > 
> > > On Wed, 2023-07-19 at 17:51 +0530, Jagan Teki wrote:
> > > > The power supply circuit in ROC-RK3399-PC is
> > > > 
> > > > Power Supply (or PPS) => FUSB => MP8859
> > > > 
> > > > VUBS pin of FUSB and IN pin of MP8859 is supplied via TYPEC_IN.
> > > > 
> > > > The MP8859 operated with 2.8V to 22V supply voltage and typical
> > > > applications this supply can be 12V.
> > > > 
> > > > This patch is trying to support the PD by changing the FUSB VBUS supply
> > > > to 12V and tune the I2C7 timings from downstream kernel.
> > > > 
> > > > Tested with PD3.0 PPS with supply voltages of 12V/3A and 20V/5A.
> > > 
> > > Hi Jagan,
> > > 
> > > This series works fine with a "dumb" (no PD negotiation) 5.1V Raspberry Pi PSU.
> > > 
> > > It also works fine with a Dell 45W USB-C Laptop Power Supply (model AA45NM170) which provides 5V@3A,9V@3A,15V@3A,20V@2.25A, where Linux master fails and just tells the USB-PD PSU to power-off.
> > 
> > I think this depends on the recent Rockchip TCPM changes. FUSB302 has
> > been a pain in the USB or else this platform would have launched a lot
> > longer ago.
> 
> Sorry, I was testing this patch on top of next-20230724 which includes https://patchwork.kernel.org/project/linux-rockchip/list/?series=757752:
> 
>  8be558dcffe69b078b34b1fa93b82acaf4ce4957 ("usb: typec: tcpm: add get max power support")
>  1e35f074399dece73d5df11847d4a0d7a6f49434 ("usb: typec: tcpm: fix cc role at port reset")
> 
> Can you check if I am missing any other patches ?

so I guess the question is, are there any new clues and/or does this patch
make the situaton better or worse for the roc-rk3399-pc board as it stands
now.

Thanks
Heiko