* [PATCH v3] dt-bindings: timer: Add support for cadence TTC PWM
@ 2024-02-26 9:33 Mubin Sayyed
2024-02-26 14:44 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Mubin Sayyed @ 2024-02-26 9:33 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, robh+dt, conor+dt, devicetree
Cc: daniel.lezcano, tglx, michal.simek, linux-kernel, Mubin Sayyed,
Krzysztof Kozlowski
Cadence TTC can act as PWM device, it will be supported through
separate PWM framework based driver. Decision to configure
specific TTC device as PWM or clocksource/clockevent would
be done based on presence of "#pwm-cells" property.
Also, interrupt property is not required for TTC PWM driver.
Update bindings to support TTC PWM configuration.
Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes for v3:
Add Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
tag
Remove bindings from subject
1/3 and 3/3 are dropped as of now (WIP).
Changes for v2:
Update subject
Modify #pwm-cells to constant 3
Update example to use generic name
link for v2:
https://lore.kernel.org/linux-arm-kernel/20231114124748.581850-2-mubin.sayyed@amd.com/T/
---
.../devicetree/bindings/timer/cdns,ttc.yaml | 22 ++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
index dbba780c9b02..da342464d32e 100644
--- a/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
+++ b/Documentation/devicetree/bindings/timer/cdns,ttc.yaml
@@ -32,12 +32,23 @@ properties:
description: |
Bit width of the timer, necessary if not 16.
+ "#pwm-cells":
+ const: 3
+
required:
- compatible
- reg
- - interrupts
- clocks
+allOf:
+ - if:
+ not:
+ required:
+ - "#pwm-cells"
+ then:
+ required:
+ - interrupts
+
additionalProperties: false
examples:
@@ -50,3 +61,12 @@ examples:
clocks = <&cpu_clk 3>;
timer-width = <32>;
};
+
+ - |
+ pwm: pwm@f8002000 {
+ compatible = "cdns,ttc";
+ reg = <0xf8002000 0x1000>;
+ clocks = <&cpu_clk 3>;
+ timer-width = <32>;
+ #pwm-cells = <3>;
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] dt-bindings: timer: Add support for cadence TTC PWM
2024-02-26 9:33 [PATCH v3] dt-bindings: timer: Add support for cadence TTC PWM Mubin Sayyed
@ 2024-02-26 14:44 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2024-02-26 14:44 UTC (permalink / raw)
To: Mubin Sayyed, krzysztof.kozlowski+dt, robh+dt, conor+dt,
devicetree
Cc: tglx, michal.simek, linux-kernel, Krzysztof Kozlowski
On 26/02/2024 10:33, Mubin Sayyed wrote:
> Cadence TTC can act as PWM device, it will be supported through
> separate PWM framework based driver. Decision to configure
> specific TTC device as PWM or clocksource/clockevent would
> be done based on presence of "#pwm-cells" property.
>
> Also, interrupt property is not required for TTC PWM driver.
> Update bindings to support TTC PWM configuration.
>
> Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes for v3:
> Add Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> tag
> Remove bindings from subject
> 1/3 and 3/3 are dropped as of now (WIP).
>
> Changes for v2:
> Update subject
> Modify #pwm-cells to constant 3
> Update example to use generic name
>
> link for v2:
> https://lore.kernel.org/linux-arm-kernel/20231114124748.581850-2-mubin.sayyed@amd.com/T/
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26 9:33 [PATCH v3] dt-bindings: timer: Add support for cadence TTC PWM Mubin Sayyed
2024-02-26 14:44 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).