From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551D6C7EE2F for ; Wed, 31 May 2023 07:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbjEaHPw (ORCPT ); Wed, 31 May 2023 03:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234536AbjEaHPv (ORCPT ); Wed, 31 May 2023 03:15:51 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36883EE for ; Wed, 31 May 2023 00:15:50 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5147dce372eso7885697a12.0 for ; Wed, 31 May 2023 00:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685517348; x=1688109348; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8xSd0cqAgLf+YYqiwd7XbThq636v/o3mZGXKvGoMzbA=; b=rXMRIfL0QEhBKNiJLprXa7lweF4waA04T8WOPzJERq4jvpcQa+4SdeFrItnoyZ/3iV WVsKt+Pp/MzZTbhpGj9Z+IZRrkCX81rQOrk0VZLz0LicM4240MXekISKAMCtCnCO2sr6 5FpUBr1wKOhb+gPz6ZaCZeLPaWg9QnkNJlkRtKPDC6Wew9NeBzaft2yFDmumjrN9pkPn HcR9qw9YGxsrc1ruMAC5Yc4+DyWlOQppqAilzOqzJHPm1lWCdLBS4HdHekMRLCtARyh8 vvD3dhrVShTff1NGmkI5aYkZ3FWE9k5zqpRxA6eAseXxMczKWx54ekQwbiDlB1V/AFag 3nQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685517348; x=1688109348; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8xSd0cqAgLf+YYqiwd7XbThq636v/o3mZGXKvGoMzbA=; b=UAY0DcIKx60bDoutvKW3wo38KdIM+3KU3/W7E15scVo6B88se/P40rwwYB/TIHVKO7 uofC9cny6z/te6/GksJ6VU1IhhEe5IVJHk1w5B525b/fSvk6BegedulZANcmwrhAdDKg jg7VR4bU01Ihf50YBo4QOmv/bBs5V9ukFJQAFppDmVD2lHHsx8WmAtbLEr6uCjlnVhEF wA+m/TSx4JvBm61lM6UaqIMNLCOr041I/tk2XwjP5KWT6UojeUrlTyPStaTPBIVSTRzm 3oE4z4EOw11MKz+fCtmiudfxsFR/DtPZARRbQSgsnj+e6/RY5WMmqosgCYsvOX7TUMul H2GQ== X-Gm-Message-State: AC+VfDz2wjKrA5TFWN5KnInPAvLDj+v4dcXZeETvuWpre0U118JrN2fT qhhJ7ZEqe0Y1d8TUie7Yt6cK9A== X-Google-Smtp-Source: ACHHUZ5F2hKC53ubgHiwwHDoDcx88Avzd7kTKgt28eaV0r3S69mPsGVeneI2iFV8X+/Rbm590SrJCw== X-Received: by 2002:a17:907:d91:b0:96a:8412:a444 with SMTP id go17-20020a1709070d9100b0096a8412a444mr3827146ejc.73.1685517348720; Wed, 31 May 2023 00:15:48 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id n13-20020a170906688d00b0096f641c6167sm8399073ejr.181.2023.05.31.00.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:15:48 -0700 (PDT) Message-ID: <46639d7e-95ed-35a6-a9ab-d802af4470ce@linaro.org> Date: Wed, 31 May 2023 09:15:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Content-Language: en-US To: Sridharan S N , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230531065619.9181-1-quic_sridsn@quicinc.com> <20230531065619.9181-2-quic_sridsn@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230531065619.9181-2-quic_sridsn@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/05/2023 08:56, Sridharan S N wrote: > Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35. > > Signed-off-by: Sridharan S N > --- > arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 43 +++++++++++++++++++++ > arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts | 43 +++++++++++++++++++++ > arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 43 +++++++++++++++++++++ > 3 files changed, 129 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > index 3af1d5556950..ba733b6cab06 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > +++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts > @@ -7,6 +7,8 @@ > > /dts-v1/; > > +#include > +#include > #include "ipq5332.dtsi" > > / { > @@ -20,6 +22,33 @@ > chosen { > stdout-path = "serial0"; > }; > + > + gpio_keys { No underscores in node names. > + compatible = "gpio-keys"; > + pinctrl-0 = <&gpio_keys_default>; > + pinctrl-names = "default"; > + status = "okay"; It's by default, why do you need it? Best regards, Krzysztof