From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F47C77B60 for ; Mon, 3 Apr 2023 12:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbjDCM5E (ORCPT ); Mon, 3 Apr 2023 08:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbjDCM5D (ORCPT ); Mon, 3 Apr 2023 08:57:03 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57D1B46B8 for ; Mon, 3 Apr 2023 05:57:02 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id b20so116968540edd.1 for ; Mon, 03 Apr 2023 05:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680526621; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N9PXbgDl7LeRBeujLG4sJDCnMB4TWVsRHSKuyMeCJLc=; b=Ovu9SuSRZuBTPFeZVLE4CtW9jF4sSj8AI99HjwWXOch+RnqponLdZXviwvIFo8d4Ga HfKie88WuwpL10J+WMmIdyb+nryWYi+Hvynb3tEJGxaWVSf7hfCKvhbRB1BFaACgNIuT mMAmeKPdSvtSMD+YFDtLMNj/ntAGWzz30l4eS9uURoBevGJ4dz0nTIniwp6/YjCkB6Az eBqe+OqNnQtOsA+1ue5FcRb5vmY5WZY9QAqO7hWETr5A1YD/56nARDy2GQoTE7KizoYd PajbNil5N8AygAcMFA5zN7tNgARwt/KEI1Zak6kSjn54GE8HWFIhEUVytADY33h6omCn fJWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680526621; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N9PXbgDl7LeRBeujLG4sJDCnMB4TWVsRHSKuyMeCJLc=; b=efLNJ4eDbEsKz98+PLhmFmS8q4K1okBu9wLTKdIt1PpJeaKFt4zBgmkTiAFIhlyqeg 10XXWubOhV3JmbrQT9XLaMhX97PErGCRaA7B9xgFLJna0r1qBqGkK3+ltgsdppgYqSHv ZY77W0aVQ15BafhycYsK9d4YR7Siglx7NwUtMEw+qsG7g/Ypo2cHCmSKK/mpGPuaFPM4 KxiPFssISZrWigJUrv6W7+0jmL4+W1gqkaW0GgZ20VM6ixh4eY5AmPutpDXXU/ZSUM0+ DmeFntOZwrKpKnnrISeLAUCiAsNtnHcvBS3J83Rx9JMxyDuG1g/+n8RHliGQB4eLo3wm BH2g== X-Gm-Message-State: AAQBX9ddzLH8yGnRQdMvWQylbAutm6vI9imxjScg4+gtwrEcUKPYBnwF GBkvk+lmAJM8xbT8xWeYdJMt5g== X-Google-Smtp-Source: AKy350abfZ6sIteFU0M7hfXJkWONPCgcKYoCCqznwTV3GlqPHt5XHyN3ybOGekoNoWZk7JDL60xBlg== X-Received: by 2002:aa7:d806:0:b0:4fc:3777:f630 with SMTP id v6-20020aa7d806000000b004fc3777f630mr33601867edq.0.1680526620839; Mon, 03 Apr 2023 05:57:00 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:ae90:d80:1069:4805? ([2a02:810d:15c0:828:ae90:d80:1069:4805]) by smtp.gmail.com with ESMTPSA id d12-20020a50f68c000000b004af73333d6esm4605441edn.53.2023.04.03.05.56.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 05:57:00 -0700 (PDT) Message-ID: <46658cbb-fff5-e98b-fdad-88fa683a9c75@linaro.org> Date: Mon, 3 Apr 2023 14:56:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 21/22] arch: arm64: dts: qcom: pm8150: support SID greater that 9 Content-Language: en-US To: Dmitry Baryshkov , Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Johan Hovold , Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org References: <20230401220810.3563708-1-dmitry.baryshkov@linaro.org> <20230401220810.3563708-22-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/04/2023 13:45, Dmitry Baryshkov wrote: >> Konrad >>>> + >>>> #undef PMIC_SID >>>> #undef PMIC_SID1 >>>> #undef PMIC_LABEL >>> >>> Same comment as for previous patches - all undefs must be gone. > > This means that we can not include two copies of the same PMIC (which > do have on both platforms). Consider spi15 and spi16: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8250.dtsi?h=v6.3-rc5&id=7e364e56293bb98cae1b55fd835f5991c4e96e7d#n1045 Do you see it written as #include "qcom-sm8250-spi.dtsi" with parametrizing the reg/unit address, interrupts etc? No. Neither PMIC should be. It is not a special device. Best regards, Krzysztof