From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9FD51DF26B for ; Wed, 9 Apr 2025 06:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744180940; cv=none; b=VwtVAKnnOIuyUqG5lCCQxMiPBc6dH9BfVMTLcITv6LM+Up49kY4aQSyi61hmOPNdBuxXDdnDRMEgfDmKPCZBlvDKaPj/9oX3MT9Lga1mrB/Vdbk930UJsCLkulnph79uskNFC5GzghNdeUa5QD857E1yhyPU8qPyOgVcCBwAd+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744180940; c=relaxed/simple; bh=xQKw0XbFmKGsN+GZ6nIb5nWvMnctlKZfRwk3pF7YWzI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q9X8eSewqeWINo4dVOFo7j/pcT8v/noYb1O7+Qp23ORjRUNLbCW5eoMqqcI9+BQyZRJtjfTcwr1gGmD+YK15C49z7tOaBYbwsJNgXA0Ki4k0F0QwXeXIlsSdsSNsXckRTB/g2s7WfKLVBw0XLDWUCQZSq3tuqXTyDNlAVuKSz4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eg+j2RSS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eg+j2RSS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744180937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bXOvHf+rQnYe15TmhKJ+zlI21FPd5oLP8we8fpA0shw=; b=eg+j2RSSI/r4LAyfWxHsyGuHCufeO8kBowCS+Fxco/209pkOIw3o5aK8k40LHh/L+75hog GhePLpa6j55Bq4cU5EIvesS1aeIeIEj51MSFFbrejRE7DepXaUvKbHsZiYODb7CyFkQGOK HRSQT/YGcV5dpVEYg1QYa9rkkRd/l0c= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-m7d0HUV2M7GLY8AnyzUsXg-1; Wed, 09 Apr 2025 02:42:14 -0400 X-MC-Unique: m7d0HUV2M7GLY8AnyzUsXg-1 X-Mimecast-MFC-AGG-ID: m7d0HUV2M7GLY8AnyzUsXg_1744180932 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C574319560BC; Wed, 9 Apr 2025 06:42:11 +0000 (UTC) Received: from [10.44.32.72] (unknown [10.44.32.72]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CB74D3001D0E; Wed, 9 Apr 2025 06:42:07 +0000 (UTC) Message-ID: <466681f4-22c2-4eae-aa98-ee923c148907@redhat.com> Date: Wed, 9 Apr 2025 08:42:06 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/28] mfd: zl3073x: Add register access helpers To: Andrew Lunn Cc: netdev@vger.kernel.org, Michal Schmidt , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Prathosh Satish , Lee Jones , Kees Cook , Andy Shevchenko , Andrew Morton , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20250407172836.1009461-1-ivecera@redhat.com> <20250407172836.1009461-4-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 07. 04. 25 11:03 odp., Andrew Lunn wrote: > On Mon, Apr 07, 2025 at 07:28:30PM +0200, Ivan Vecera wrote: >> Add helpers zl3073x_{read,write}_reg() to access device registers. >> These functions have to be called with device lock that can be taken >> by zl3073x_{lock,unlock}() or a caller can use defined guard. > > regmap has locking. It would be good to explain in detail why regmap > locking is not sufficient. > > Andrew > Yes, it is not sufficient. I will describe this in v2 commit description. Thanks, Ivan