From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings Date: Tue, 07 Jan 2014 16:44:30 +0100 Message-ID: <4687115.Uo6IImEscY@wuerfel> References: <1387785725-24262-1-git-send-email-tinamdar@apm.com> <201401071635.02006.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <201401071635.02006.arnd@arndb.de> Sender: linux-pci-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Tanmay Inamdar , devicetree@vger.kernel.org, Jon Masters , linux-doc@vger.kernel.org, Catalin Marinas , patches , "linux-kernel@vger.kernel.org" , Grant Likely , Rob Landley , linux-pci@vger.kernel.org, Bjorn Helgaas List-Id: devicetree@vger.kernel.org On Tuesday 07 January 2014 16:35:01 Arnd Bergmann wrote: > > >> +SoC specific DT Entry: > > >> + pcie0: pcie@1f2b0000 { > > >> + status = "disabled"; > > >> + device_type = "pci"; > > >> + compatible = "xgene,pcie"; > > >> + #interrupt-cells = <1>; > > >> + #size-cells = <2>; > > >> + #address-cells = >; > > >> + reg = < 0x00 0x1f2b0000 0x0 0x00010000>; > > >> + ranges = <0x02000000 0x0 0x00000000 0xe0 0x00000000 0x0 0x10000000 /* mem*/ > > > > > > > > > Also, do you support no prefetchable memory? > > > > HW has either IO or Memory regions for mapping device's memory space. > > There is no separate prefetchable memory space. > > Are you sure the memory is non-prefetchable then? I would have expected > 0x42000000 rather than 0x02000000, but I could be misremembering it. Nevermind. I just checked and you are right: if you only have one memory range, it has to be non-prefetchable. Arnd