From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varshini Rajendran <varshini.rajendran@microchip.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
Date: Fri, 28 Jul 2023 13:46:51 +0200 [thread overview]
Message-ID: <46927d97-72a1-8815-38d3-828797c0f3dd@linaro.org> (raw)
In-Reply-To: <f7186a62-19a1-5d72-ee1b-255b81fb8abe@linaro.org>
On 28/07/2023 13:40, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:23, Varshini Rajendran wrote:
>> Add bindings for SAM9X7's pmc.
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> .../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> index c1bdcd9058ed..ce0d99503645 100644
>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - atmel,sama5d4-pmc
>> - microchip,sam9x60-pmc
>> - microchip,sama7g5-pmc
>> + - microchip,sam9x7-pmc
>> - const: syscon
>
> Where is the change in allOf:if:then:? No need for it? Why? Where is the
> driver change?
>
> Please do not send huge series to 50 different people and subsystems.
> With your lack of threading it is so difficult to review.
You already got this comment and not much improved:
https://lore.kernel.org/all/f2f8cabf-ca4d-c6f3-5561-b24334be89d1@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-28 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 10:23 [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller Varshini Rajendran
2023-07-28 11:40 ` Krzysztof Kozlowski
2023-07-28 11:46 ` Krzysztof Kozlowski [this message]
2023-08-10 5:31 ` Varshini.Rajendran
2023-08-10 6:02 ` Krzysztof Kozlowski
2023-08-10 6:07 ` Varshini.Rajendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46927d97-72a1-8815-38d3-828797c0f3dd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox