From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Liu Ying <victor.liu@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
saravanak@google.com, gregkh@linuxfoundation.org,
geert+renesas@glider.be
Subject: Re: [PATCH 2/3] drivers: bus: simple-pm-bus: Use clocks
Date: Tue, 2 Aug 2022 12:59:30 +0200 [thread overview]
Message-ID: <4697e12b-e9e3-100e-190c-7eece43b3a05@linaro.org> (raw)
In-Reply-To: <7b0d5f68-491e-ace4-5970-92ef795ec5a7@linaro.org>
On 02/08/2022 12:56, Krzysztof Kozlowski wrote:
> On 02/08/2022 09:13, Liu Ying wrote:
>> Simple Power-Managed bus controller may need functional clock(s)
>> to be enabled before child devices connected to the bus can be
>> accessed. Get the clock(s) as a bulk and enable/disable the
>> clock(s) when the bus is being power managed.
>>
>> One example is that Freescale i.MX8qxp pixel link MSI bus controller
>> needs MSI clock and AHB clock to be enabled before accessing child
>> devices.
>
> No, because it is not simple bus anymore.
Hm, actually I take back my no, as this pm-bus was done for such
purpose. Since we allow power domains, we should also allow clocks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-02 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:13 [PATCH 0/3] drivers: bus: Add Freescale i.MX8qxp pixel link MSI bus support Liu Ying
2022-08-02 7:13 ` [PATCH 1/3] drivers: bus: simple-pm-bus: Populate simple MFD child devices Liu Ying
2022-08-02 7:13 ` [PATCH 2/3] drivers: bus: simple-pm-bus: Use clocks Liu Ying
2022-08-02 10:56 ` Krzysztof Kozlowski
2022-08-02 10:59 ` Krzysztof Kozlowski [this message]
2022-08-02 7:13 ` [PATCH 3/3] dt-bindings: bus: Add Freescale i.MX8qxp pixel link MSI bus binding Liu Ying
2022-08-02 11:04 ` Krzysztof Kozlowski
2022-08-02 15:47 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4697e12b-e9e3-100e-190c-7eece43b3a05@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=saravanak@google.com \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).