From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Sperl Subject: Re: [PATCH V2 0/2] serial: bcm2835: add bcm2835 auxiliar uart driver Date: Sun, 10 Jan 2016 16:45:41 +0100 Message-ID: <46FD7886-510C-4F0F-A039-500D5438207B@martin.sperl.org> References: <1452344854-2576-1-git-send-email-kernel@martin.sperl.org> <1057226922.507844.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1057226922.507844.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , Eric Anholt , Jiri Slaby , Greg Kroah-Hartman , Stephen Warren , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org > On 10.01.2016, at 16:05, Stefan Wahren wrote= : >=20 > Hi Martin, >=20 >> kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org hat am 9. Januar 2016 um 14:07 geschrieben: >>=20 >>=20 >> From: Martin Sperl >>=20 >> This patch series adds the bcm2835aux uart driver, which is created >> as a wrapper arround the 8250 driver (based on recommendations by >> Stephen Warren) >>=20 >> The device tree patch itself is not included yet because this >> patch requires the clk-bcm2835aux driver, which is right now only >> in clk-next, but should become available with 4.5. >=20 > it doesn't make sense without the device tree patch. IMHO it's okay a= s long as > you point out the dependency and set the node status to disable. I agree in principle, but it is the same as with the spi-bcm2835aux dri= ver, where I had provided a patch to the dt, that still has not been applied yet, but with the driver itself already in the kernel. Also the reorganisation of the dt to support the bcm2836 makes this another moving target. The other concern is that we would need to use defines included from "dt-bindings/clock/bcm2835aux.h=E2=80=9D and without those the dt = will not work. =46or the record: this is what would be required: uart1: uart@7e215040 { compatible =3D "brcm,bcm2835-aux-uart"; reg =3D <0x7e215040 0x40>; interrupts =3D <1 29>; clocks =3D <&aux BCM2835_AUX_CLOCK_UART>; status =3D "disabled"; }; I can respin the whole patchset to include this as well if you tell me = to. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html