From: barnabas.czeman@mainlining.org
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: Add Redmi Go
Date: Mon, 09 Mar 2026 22:36:40 +0100 [thread overview]
Message-ID: <46a3f0ff1a5c20e8bd4a4c1efb16960d@mainlining.org> (raw)
In-Reply-To: <390f4c8b89f3465924d6ef95bccccc6a@mainlining.org>
On 2026-03-09 22:19, barnabas.czeman@mainlining.org wrote:
> On 2026-03-09 13:53, Konrad Dybcio wrote:
>> On 3/5/26 6:28 PM, Barnabás Czémán wrote:
>>> Redmi Go (tiare) is like Redmi 5A with small differences like
>>> charging,
>>> fuel gauge and different speaker codec.
>>>
>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>>> arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts | 27
>>> +++++++++++++++++++++++
>>> 2 files changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile
>>> b/arch/arm64/boot/dts/qcom/Makefile
>>> index 20e161e843ed..a74598cf0b47 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM) +=
>>> msm8916-wingtech-wt88047.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8916-yiming-uz801v3.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-riva.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-rolex.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM) += msm8917-xiaomi-tiare.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8929-wingtech-wt82918hd.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8937-xiaomi-land.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8939-asus-z00t.dtb
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts
>>> b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts
>>> new file mode 100644
>>> index 000000000000..c3a74530c34c
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts
>>> @@ -0,0 +1,27 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * Copyright (c) 2026, Barnabas Czeman
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "msm8917-xiaomi-riva-common.dtsi"
>>> +
>>> +/ {
>>> + model = "Xiaomi Redmi Go (tiare)";
>>> + compatible = "xiaomi,tiare", "qcom,msm8917";
>>> +
>>> + qcom,board-id = <0x1000b 1>;
>>
>> Could you please double-check this? Riva and Rolex seem to have
>> properly different values there, but this one mimics one of the
>> values for Rolex.
> riva value is depends from the bootloader, Oreo bootloader using same
> value
> like rolex and tiare, 2nd entry in the board-id is not used so i should
> remove it.
> Here is some more context:
> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-riva.dts
> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-common.dts
>
I have find out this qcom,board-id = <0x1000b 1>, <0x1000b 2>; works
with both bootloader version
on riva but if i set only one of them, the bootloader version will be
limited.
>>
>> FWIW these values are almost never properly fused so I wouldn't be
>> surprised if this was a fail.
>>
>> Konrad
next prev parent reply other threads:[~2026-03-09 21:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 17:28 [PATCH 0/5] Commonize Redmi 5A for 4A and GO Barnabás Czémán
2026-03-05 17:28 ` [PATCH 1/5] arm64: dts: qcom: msm8917-xiaomi-riva: Commonize for Redmi " Barnabás Czémán
2026-03-06 8:21 ` Krzysztof Kozlowski
2026-03-09 12:55 ` Konrad Dybcio
2026-03-09 21:48 ` barnabas.czeman
2026-03-10 12:57 ` barnabas.czeman
2026-03-10 13:04 ` Konrad Dybcio
2026-03-10 13:11 ` barnabas.czeman
2026-03-10 13:21 ` Konrad Dybcio
2026-03-10 13:26 ` barnabas.czeman
2026-03-10 13:41 ` Konrad Dybcio
2026-03-05 17:28 ` [PATCH 2/5] dt-bindings: arm: qcom: Add Redmi 4A Barnabás Czémán
2026-03-09 10:57 ` Krzysztof Kozlowski
2026-03-09 12:50 ` Konrad Dybcio
2026-03-09 12:54 ` Krzysztof Kozlowski
2026-03-05 17:28 ` [PATCH 3/5] arm64: dts: " Barnabás Czémán
2026-03-09 12:52 ` Konrad Dybcio
2026-03-09 21:25 ` barnabas.czeman
2026-03-05 17:28 ` [PATCH 4/5] dt-bindings: arm: qcom: Add Redmi Go Barnabás Czémán
2026-03-06 8:21 ` Krzysztof Kozlowski
2026-03-06 8:29 ` Krzysztof Kozlowski
2026-03-05 17:28 ` [PATCH 5/5] arm64: dts: " Barnabás Czémán
2026-03-09 12:53 ` Konrad Dybcio
2026-03-09 21:19 ` barnabas.czeman
2026-03-09 21:36 ` barnabas.czeman [this message]
2026-03-10 12:31 ` Konrad Dybcio
2026-03-10 12:47 ` barnabas.czeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a3f0ff1a5c20e8bd4a4c1efb16960d@mainlining.org \
--to=barnabas.czeman@mainlining.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox