From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BAD31DD91 for ; Fri, 7 Nov 2025 11:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762514053; cv=none; b=UfgTbAGYBs8LUESKOIuKH0fQBk6OSpOhqP7nPfl7JnSmK5zwAdZ9OhLZeU9SYU8uQcoo7/rfGFS6BmAp5zHorMQDu1XOJzNQUfrIAJvJ6I30lbL62nIG8S2q4nogql/ub+GfU+cE3Ln76vHSGkoTJuXSbpc7uUoQ4FVoSQoWxpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762514053; c=relaxed/simple; bh=Z7IPw5CPkkm8JcNSROY9Rb8Po+uOfMzr3L63jIIDVFM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WIh4VobSKhx2QLcbjtF0OrzwjZ10A/l7H7EFcPoJ/6feTYsSdx0wKpf1cLbTkuhXQz5Q24cIzCFEj615a2FeMhIArIXq25zAkDpaWeJeRGB1cf87/rovzyk0VD21vizTlhphH+dI+r/X+HGzPlF+rkGqesHUqoCewX01IbtY474= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=luiBTTBq; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="luiBTTBq" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b3e7cc84b82so118866666b.0 for ; Fri, 07 Nov 2025 03:14:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762514050; x=1763118850; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Z7IPw5CPkkm8JcNSROY9Rb8Po+uOfMzr3L63jIIDVFM=; b=luiBTTBqWyYVxLyfjIjqWhL/TJ+aTGylHamIgM1BRtHW5ij3i3o5qpvRxapwh7561R w4GRGBK1McbigXxWw+/q6TgbJYU/E3UViPtoXds9dTCc5575WylTzZcVG+/rCsYKnQTw vSrNbf1MluN1tWVqTd+CNpC9Xpf1DUXSpmjY1X34V2ZVpnn/rvI+fbAOALIfHo0hV9Bj 9tGlvH6KP9jreduQoMZ5wtNRU45+XI/5DCPuUKvIWmRZ3xciAee9jK+MAvSR1V5b+6o4 D+v1nPgUb9YPcDqWNcIVJy2IwY1VCKPsJUjvsVbTtGlc4HSGP5HmTFOSzLnYYT5srUiO Ah+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762514050; x=1763118850; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z7IPw5CPkkm8JcNSROY9Rb8Po+uOfMzr3L63jIIDVFM=; b=K7TA/xBNYG91W8qmQGOSCmpvGHjJgUuFgpKOeL4zh4gfRLQ/Nomxf56WhZA7iJ8Jwi r2/jMt/VTAA8wOLIBw5xg1L+G4K/rEuxCiGXGI+nYYKD9Xczw7U82aFWWXhEcjAP6sQf tccO/ES4yvVjaruXoUlE0N2sQ/xn7EAUyfcDwu+lhKmbR7E1WOENGm61UNmhuz+K8HI8 qufBxGYkRG/Dv83sPFNZiktq81WQRW23aJXh6QfCeiFaOFh3DlF4cfDaLxn7P8CmcBLG LBOCF/xXaEPrP/K8+By1O2C9Jz0snCpMipWuz++r0kVr6DT2i28cvd7n3h1BcINS7lp3 clTw== X-Forwarded-Encrypted: i=1; AJvYcCVXfcFzdcO8RgWuhWOKJBJZWudLz0P4a3YsLawcR3OIOXo9Fz+72tWodAYkTxv4JTl46U66cHfUwdG6@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Ux4Of8hfr0jcQtIE4Ja7eVdj3dsUeVkWqBUNhgR4WLZKvva5 xMb4nACUvpZfMLxcd0N0e2TA7PGtBQTo7vCPsXNCfCg6azJCHIdokc/8gnD5aG2juE4= X-Gm-Gg: ASbGncvFG3NpN7E8ZFV4eWdqxcQkJlw1PbQ6qqTVmQy0VGzNFRur2SX76JOe6S6lj6E Nf32jhbXfZ1XbS1bbwOzRJgl8X7hPnQPZs7g5FHN9H1GU3rZ88oTDMlKFITrlh1LCcswylKoWwr KDgb/DDRzA6pxwwN3UPSY4M61Cp4Dpni3m9EdHP82WZyiybeIcQXL50WwH4xXa0+ipesy4o/zuS PO1bqqUj0RSruABTlC0OG9TbDJABcX6RMka1pN1eYdMhzA0600E/yqhVXeLTx2mpfsPZQO+WVsg kqjeUu3dL3gT3/rCBbUiUsHLxw1U/eUjbReryWwY3ktkplH8ynNj+iyVvRMyhEDyrO7eB2IoEio LlnTltIyoDG9id7H1ZM314CisTWuc7FOTbhbu359DrPK+bMX/f50SySuRf9NnFyB9lSYi2GwoKH IULYs4FpYkKz3fACs8Lv8fNOatNC8BWPB8jA== X-Google-Smtp-Source: AGHT+IFXZ+Ksq+F4K5MrYL+0Ly42CejCgVP+A4n4kcnrW9kMuuDkI5VXyfDYyP5cJO6HwQMmVPf1ww== X-Received: by 2002:a17:907:3f28:b0:b3d:5088:213d with SMTP id a640c23a62f3a-b72c0cf643dmr254948266b.42.1762514049980; Fri, 07 Nov 2025 03:14:09 -0800 (PST) Received: from [172.20.148.133] ([87.213.113.147]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bf97e457sm212986366b.43.2025.11.07.03.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Nov 2025 03:14:09 -0800 (PST) Message-ID: <46b008c946e36ea0b317691356ff874c4a78882d.camel@linaro.org> Subject: Re: [PATCH v3 04/20] regulator: dt-bindings: add s2mpg11-pmic regulators From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski Cc: Tudor Ambarus , Rob Herring , Conor Dooley , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Date: Fri, 07 Nov 2025 11:14:09 +0000 In-Reply-To: <20251104-zircon-lobster-of-agility-cbcbb0@kuoka> References: <20251103-s2mpg1x-regulators-v3-0-b8b96b79e058@linaro.org> <20251103-s2mpg1x-regulators-v3-4-b8b96b79e058@linaro.org> <20251104-zircon-lobster-of-agility-cbcbb0@kuoka> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-2+build3 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-11-04 at 10:39 +0100, Krzysztof Kozlowski wrote: > On Mon, Nov 03, 2025 at 07:14:43PM +0000, Andr=C3=A9 Draszik wrote: > > +=C2=A0 The S2MPG11 PMIC provides 12 buck, 1 buck-boost, and 15 LDO reg= ulators. > > + > > +=C2=A0 See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.= yaml for > > +=C2=A0 additional information and example. > > + > > +definitions: >=20 > defs: All existing bindings are using definitions, not defs. Shouldn't this stay consistent? [...] > > +patternProperties: > > +=C2=A0 # 12 bucks > > +=C2=A0 "^buck(([1-9]|10)s|[ad])$": > > +=C2=A0=C2=A0=C2=A0 type: object > > +=C2=A0=C2=A0=C2=A0 $ref: regulator.yaml# > > +=C2=A0=C2=A0=C2=A0 unevaluatedProperties: false > > +=C2=A0=C2=A0=C2=A0 description: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Properties for a single buck regulator. > > + > > +=C2=A0=C2=A0=C2=A0 allOf: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - $ref: "#/definitions/s2mpg11-ext-cont= rol" >=20 > defs >=20 > > + > > +=C2=A0=C2=A0=C2=A0 properties: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 regulator-ramp-delay: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 enum: [6250, 12500, 25000] > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default: 6250 > > + >=20 > .... >=20 >=20 > > +=C2=A0=C2=A0=C2=A0 allOf: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - $ref: "#/definitions/s2mpg11-ext-cont= rol" > > + > > +=C2=A0=C2=A0=C2=A0 properties: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 regulator-ramp-delay: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 enum: [6250, 12500] > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default: 6250 > > + > > +additionalProperties: false >=20 > This goes to the end, after allOf, see example-schema. Will fix. Thanks for your review Krzysztof. Cheers, A.