devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
@ 2025-10-02 18:44 Eric Gonçalves
  2025-10-03  1:31 ` Dmitry Baryshkov
  2025-10-03 13:03 ` Konrad Dybcio
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Gonçalves @ 2025-10-02 18:44 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring
  Cc: devicetree, linux-arm-msm, linux-kernel

The S20 series has additional reserved pins for the fingerprint sensor,
GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.

Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
Changes in v4:
- Removed accidental , instead of ; in the last line

Changes in v3:
- Actually fixed <40 4> indentation
Sorry, I still had my editor on 4 spaces a tab

Changes in v2:
- "Fixed" the formatting of the <40 4> line
- Added Fixes tag
---
 arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
index 96662bf9e527..7696b147e7da 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
@@ -159,7 +159,8 @@ &pon_resin {
 };
 
 &tlmm {
-	gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+	gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+			       <40 4>; /* Unused */
 };
 
 &usb_1 {
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
  2025-10-02 18:44 [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
@ 2025-10-03  1:31 ` Dmitry Baryshkov
  2025-10-03 13:03 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-10-03  1:31 UTC (permalink / raw)
  To: Eric Gonçalves
  Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
	Rob Herring, devicetree, linux-arm-msm, linux-kernel

On Thu, Oct 02, 2025 at 06:44:59PM +0000, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
> 
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
  2025-10-02 18:44 [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
  2025-10-03  1:31 ` Dmitry Baryshkov
@ 2025-10-03 13:03 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-10-03 13:03 UTC (permalink / raw)
  To: Eric Gonçalves, Bjorn Andersson, Konrad Dybcio, Conor Dooley,
	Krzysztof Kozlowski, Rob Herring
  Cc: devicetree, linux-arm-msm, linux-kernel

On 10/2/25 8:44 PM, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
> 
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-03 13:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-02 18:44 [PATCH v4] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
2025-10-03  1:31 ` Dmitry Baryshkov
2025-10-03 13:03 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).