* [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups @ 2017-02-08 5:31 Dawei Chien 2017-02-09 21:25 ` Matthias Brugger 0 siblings, 1 reply; 5+ messages in thread From: Dawei Chien @ 2017-02-08 5:31 UTC (permalink / raw) To: Zhang Rui, Eduardo Valentin Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, Matthias Brugger, linux-pm-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo, Dawei Chien Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. However, Currently thermal driver don't need read TEMP_MSR3 since thermal controller only use 3 sensors for each thermal bank. Signed-off-by: Dawei Chien <dawei.chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> --- drivers/thermal/mtk_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index 34169c3..c124151 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -191,7 +191,7 @@ struct mtk_thermal { }; const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 }; const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups 2017-02-08 5:31 [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien @ 2017-02-09 21:25 ` Matthias Brugger [not found] ` <ebdf54af-6290-9654-c475-53dd580582a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Matthias Brugger @ 2017-02-09 21:25 UTC (permalink / raw) To: Dawei Chien, Zhang Rui, Eduardo Valentin Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-pm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, srv_heupstream, Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo On 02/08/2017 06:31 AM, Dawei Chien wrote: > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > However, Currently thermal driver don't need read TEMP_MSR3 since > thermal controller only use 3 sensors for each thermal bank. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- Actually the commit message should state: Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") ...and get backported to v4.9 and v4.10. Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Regards, Matthias > drivers/thermal/mtk_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 34169c3..c124151 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -191,7 +191,7 @@ struct mtk_thermal { > }; > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > }; > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { > ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <ebdf54af-6290-9654-c475-53dd580582a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups [not found] ` <ebdf54af-6290-9654-c475-53dd580582a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2017-02-13 9:01 ` Dawei Chien 2017-02-19 1:23 ` Eduardo Valentin 0 siblings, 1 reply; 5+ messages in thread From: Dawei Chien @ 2017-02-13 9:01 UTC (permalink / raw) To: Matthias Brugger Cc: Zhang Rui, Eduardo Valentin, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-pm-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo Hi, Matthias, On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: > > On 02/08/2017 06:31 AM, Dawei Chien wrote: > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > > However, Currently thermal driver don't need read TEMP_MSR3 since > > thermal controller only use 3 sensors for each thermal bank. > > > > Signed-off-by: Dawei Chien <dawei.chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > > --- > > Actually the commit message should state: > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > ...and get backported to v4.9 and v4.10. > > Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Regards, > Matthias Thank you for your review. I would add below commit message on next version. However, currently 8173 thermal driver would not read TEMP_MSR3 since thermal driver only use 3 sensors on each bank, this patch would not effect temperature. Only if thermal driver use 4 sensors on any thermal bank, would read third sensor two times, and lose fourth sensor of vale. Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > drivers/thermal/mtk_thermal.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > > index 34169c3..c124151 100644 > > --- a/drivers/thermal/mtk_thermal.c > > +++ b/drivers/thermal/mtk_thermal.c > > @@ -191,7 +191,7 @@ struct mtk_thermal { > > }; > > > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > > }; > > > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups 2017-02-13 9:01 ` Dawei Chien @ 2017-02-19 1:23 ` Eduardo Valentin [not found] ` <20170219012306.GA28525-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Eduardo Valentin @ 2017-02-19 1:23 UTC (permalink / raw) To: Dawei Chien Cc: Matthias Brugger, Zhang Rui, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-pm, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek, srv_heupstream, Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote: > Hi, Matthias, > > On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: > > > > On 02/08/2017 06:31 AM, Dawei Chien wrote: > > > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > > > However, Currently thermal driver don't need read TEMP_MSR3 since > > > thermal controller only use 3 sensors for each thermal bank. > > > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > > --- > > > > Actually the commit message should state: > > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > > > > ...and get backported to v4.9 and v4.10. > > > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > > Regards, > > Matthias > > Thank you for your review. I would add below commit message on next > version. However, currently 8173 thermal driver would not read TEMP_MSR3 > since thermal driver only use 3 sensors on each bank, this patch would > not effect temperature. > Only if thermal driver use 4 sensors on any thermal bank, would read > third sensor two times, and lose fourth sensor of vale. > Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") > Please send a new version with the tag in the commit message. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20170219012306.GA28525-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>]
* Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups [not found] ` <20170219012306.GA28525-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> @ 2017-02-20 11:30 ` Matthias Brugger 0 siblings, 0 replies; 5+ messages in thread From: Matthias Brugger @ 2017-02-20 11:30 UTC (permalink / raw) To: Eduardo Valentin, Dawei Chien Cc: Zhang Rui, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King, linux-pm-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w, Sascha Hauer, Fan Chen, Eddie Huang, Yingjoe Chen, Erin Lo On 19/02/17 02:23, Eduardo Valentin wrote: > On Mon, Feb 13, 2017 at 05:01:58PM +0800, Dawei Chien wrote: >> Hi, Matthias, >> >> On Thu, 2017-02-09 at 22:25 +0100, Matthias Brugger wrote: >>> >>> On 02/08/2017 06:31 AM, Dawei Chien wrote: >>>> Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. >>>> However, Currently thermal driver don't need read TEMP_MSR3 since >>>> thermal controller only use 3 sensors for each thermal bank. >>>> >>>> Signed-off-by: Dawei Chien <dawei.chien-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> >>>> --- >>> >>> Actually the commit message should state: >>> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") >>> >>> ...and get backported to v4.9 and v4.10. >>> >>> Reviewed-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> >>> Regards, >>> Matthias >> >> Thank you for your review. I would add below commit message on next >> version. However, currently 8173 thermal driver would not read TEMP_MSR3 >> since thermal driver only use 3 sensors on each bank, this patch would >> not effect temperature. >> Only if thermal driver use 4 sensors on any thermal bank, would read >> third sensor two times, and lose fourth sensor of vale. >> Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") >> > > Please send a new version with the tag in the commit message. > And don't forget to add stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org so that the fix ends up in the older kernels as well. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-20 11:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 5:31 [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Dawei Chien
2017-02-09 21:25 ` Matthias Brugger
[not found] ` <ebdf54af-6290-9654-c475-53dd580582a0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-13 9:01 ` Dawei Chien
2017-02-19 1:23 ` Eduardo Valentin
[not found] ` <20170219012306.GA28525-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-02-20 11:30 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).