From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init() Date: Sat, 30 Sep 2017 16:00:28 +0300 Message-ID: <46f6e8f0-0398-e33e-10fc-d0db6ce06db0@cogentembedded.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chunfeng Yun , Greg Kroah-Hartman , Felipe Balbi , Rob Herring Cc: Mathias Nyman , Matthias Brugger , Mark Rutland , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello! On 9/28/2017 3:17 AM, Chunfeng Yun wrote: > When fail to get irq number, platform_get_irq() may return Failing. IRQ. :-) > -EPROBE_DEFER, but we ignore it and always return -ENODEV, > so fix it. > > Signed-off-by: Chunfeng Yun > --- > drivers/usb/mtu3/mtu3_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c > index 99c65b0..9475798 100644 > --- a/drivers/usb/mtu3/mtu3_core.c > +++ b/drivers/usb/mtu3/mtu3_core.c > @@ -774,9 +774,9 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb) > return -ENOMEM; > > mtu->irq = platform_get_irq(pdev, 0); > - if (mtu->irq <= 0) { > + if (mtu->irq < 0) { This is good as the function no longer returns 0 on error. Even when it did, 0 could mean a valid IRQ as well... > dev_err(dev, "fail to get irq number\n"); > - return -ENODEV; > + return mtu->irq; > } > dev_info(dev, "irq %d\n", mtu->irq); > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html