public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: tessolveupstream@gmail.com
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
Date: Thu, 8 Jan 2026 18:32:23 +0530	[thread overview]
Message-ID: <46fac652-e6bd-43c9-a57e-e76d66239407@gmail.com> (raw)
In-Reply-To: <4d95232c-f59a-42c3-9eb4-934b58429d25@oss.qualcomm.com>



On 08-01-2026 14:06, Konrad Dybcio wrote:
>>>>> + */
>>>>> +/dts-v1/;
>>>>> +/plugin/;
>>>>> +
>>>>> +#include <dt-bindings/gpio/gpio.h>
>>>>> +
>>>>> +&{/} {
>>>>> +	backlight: backlight {
>>>>> +		compatible = "gpio-backlight";
>>>>> +		gpios = <&tlmm 59 GPIO_ACTIVE_HIGH>,
>>>>> +			<&tlmm 115 GPIO_ACTIVE_HIGH>;
>>>>> +		default-on;
>>>>> +	};
>>>>> +
>>>>> +	hdmi_connector: hdmi-out {
>>>>> +		status = "disabled";
>>>>> +	};
>>>> This should be a &label_reference
>>>>
>>> Okay, will add it in the next patch.
>> I noticed that in several existing .dtso files, the root node is
>> commonly referenced as &{/}. In your comment, you suggested using &label_reference. Could you please clarify which specific label or 
>> node you would like me to update here.
> &{/} must be used for root nodes in a .dtso (for it to compile). I meant
> using a &label_reference for hdmi_connector

Thank you for clarifying. I’ve updated the patch to move 
hdmi_connector out of the root node and reference it using 
&hdmi_connector instead of defining it under &{/} like below:

git diff arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.
diff --git a/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,
index 5393d1dc7fea..bd1cbfc866b7 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
+++ b/arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
@@ -15,10 +15,6 @@ backlight: backlight {
                default-on;
        };

-       hdmi_connector: hdmi-out {
-               status = "disabled";
-       };
-
        panel-lvds {
                compatible = "auo,g133han01";

@@ -49,6 +45,10 @@ lvds_panel_out_b: endpoint {
        };
 };

+&hdmi_connector {
+       status = "disabled";
+};
+
 &i2c1 {
        clock-frequency = <400000>;

Could you please confirm if this change aligns with your 
expectation.




  reply	other threads:[~2026-01-08 13:02 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30 13:02 [PATCH v10 0/5] Add Qualcomm Technologies, Inc. Talos EVK SMARC support Sudarshan Shetty
2025-12-30 13:02 ` [PATCH v10 1/5] dt-bindings: arm: qcom: talos-evk: Add QCS615 Talos EVK SMARC platform Sudarshan Shetty
2025-12-30 15:03   ` Krzysztof Kozlowski
2026-01-04 13:11     ` tessolveupstream
2026-01-05  7:12       ` Krzysztof Kozlowski
2026-01-07  6:58         ` tessolveupstream
2026-01-07  7:20           ` Krzysztof Kozlowski
2026-01-07 11:17             ` Konrad Dybcio
2026-01-14  6:53               ` tessolveupstream
2025-12-30 13:02 ` [PATCH v10 2/5] dt-bindings: backlight: gpio-backlight: allow multiple GPIOs Sudarshan Shetty
2026-01-05 15:52   ` Bjorn Andersson
2025-12-30 13:02 ` [PATCH v10 3/5] backlight: gpio: add support for multiple GPIOs for backlight control Sudarshan Shetty
2026-01-05 15:38   ` Bjorn Andersson
2026-01-07  5:57     ` tessolveupstream
2026-01-07  8:12       ` Dmitry Baryshkov
2025-12-30 13:02 ` [PATCH v10 4/5] arm64: dts: qcom: talos: Fix inconsistent USB PHY node naming Sudarshan Shetty
2025-12-30 14:42   ` Dmitry Baryshkov
2026-01-07  8:23   ` yuanjiey
2026-01-08  4:51     ` tessolveupstream
2025-12-30 13:02 ` [PATCH v10 5/5] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board Sudarshan Shetty
2025-12-30 14:45   ` Dmitry Baryshkov
2025-12-30 14:51   ` Konrad Dybcio
2026-01-04 13:46     ` tessolveupstream
2026-01-05 22:13       ` Dmitry Baryshkov
2026-01-06  7:30         ` tessolveupstream
2026-01-08  7:36       ` tessolveupstream
2026-01-08  8:36         ` Konrad Dybcio
2026-01-08 13:02           ` tessolveupstream [this message]
2026-01-08 13:06             ` Konrad Dybcio
2026-01-07  8:37   ` yuanjiey
2026-01-08  9:29     ` tessolveupstream
2026-01-08 13:14       ` Konrad Dybcio
2026-01-09  7:21         ` tessolveupstream

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46fac652-e6bd-43c9-a57e-e76d66239407@gmail.com \
    --to=tessolveupstream@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox