Re: [PATCH v2] dt-bindings: misc: Add binding for BCM63138 BootLUT

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/06/2025 08:48, Shankari Anand wrote:
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC (and consider --no-git-fallback argument, so you will
>> not CC people just because they made one commit years ago). It might
>> happen, that command when run on an older kernel, gives you outdated
>> entries. Therefore please be sure you base your patches on recent Linux
>> kernel.
> 
> 
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on some
>> ancient tree (don't, instead use mainline) or work on fork of kernel
>> (don't, instead use mainline). Just use b4 and everything should be
>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>> patches to the patchset.
>> </form letter>
> 
> 
> Thankyou, I shall use b4 henceforth and shall be careful of sending
> the mail to the correct maintainers.


Reply inline, not top-posting by copying some parts of message and
ignoring the rest. I assume you will implement all comments, not only
what you copied here.

> 
> 
>> There are bindings for this already, why are you duplicating them? Maybe
>> you want to convert? Anyway, commit msg should explain that.
> 
> 
> Yes, there's already a YAML binding for brcm,bcmbca which covers the
> brcm,bcm63138 compatible. However, that schema doesn't account for the
> brcm,bcm63138-bootlut node or its register region, which is used for
> secondary CPU initialization.I’ll update the commit message to clarify
> that this is not a duplicate but an addition for a previously
> undocumented subnode.

No. You must not duplicate the code, but instead drop the parts of
existing TXT binding while converting. This also means conversion should
be complete, e.g. if any CPU needs to have a phandle to bootlut etc.

> 
> 
> On Tue, Jun 10, 2025 at 11:50 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 08/06/2025 20:37, Shankari Anand wrote:
>>> Add a device tree binding schema for the Broadcom BCM63138 BootLUT node.
>>> This binding specifies required properties for the boot lookup table used
>>> for secondary CPU initialization on BCM63138 SoCs, including 'compatible'
>>> and 'reg' properties.
>>>
>>> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
>>> ---
>>>  .../bindings/misc/brcm,bcm63138-bootlut.yaml  | 35 +++++++++++++++++++
>>
>>
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC (and consider --no-git-fallback argument, so you will
>> not CC people just because they made one commit years ago). It might
>> happen, that command when run on an older kernel, gives you outdated
>> entries. Therefore please be sure you base your patches on recent Linux
>> kernel.
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on some
>> ancient tree (don't, instead use mainline) or work on fork of kernel
>> (don't, instead use mainline). Just use b4 and everything should be
>> fine, although remember about `b4 prep --auto-to-cc` if you added new
>> patches to the patchset.
>> </form letter>
>>
>>
>>>  1 file changed, 35 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/misc/brcm,bcm63138-bootlut.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/brcm,bcm63138-bootlut.yaml b/Documentation/devicetree/bindings/misc/brcm,bcm63138-bootlut.yaml
>>> new file mode 100644
>>> index 000000000000..af4b879ba6bc
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/misc/brcm,bcm63138-bootlut.yaml
>>> @@ -0,0 +1,35 @@
>>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/misc/brcm,bcm63138-bootlut.yaml#
>>
>> There are bindings for this already, why are you duplicating them? Maybe
>> you want to convert? Anyway, commit msg should explain that.
>>
>>
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Broadcom BCM63138 Boot Lookup Table
>>> +
>>> +maintainers:
>>> +  - William Zhang <william.zhang@broadcom.com>
>>> +
>>> +description: |
>>> +  This describes the Boot Lookup Table (BootLUT) region for the BCM63138
>>
>> Describe the hardware not "what this document is".
>>>>> +...
>>
>>
>> Best regards,
>> Krzysztof


Best regards,
Krzysztof