devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix LoongArch dtbs_check warnings
@ 2025-12-09 14:00 Yao Zi
  2025-12-09 14:00 ` [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property Yao Zi
  0 siblings, 1 reply; 4+ messages in thread
From: Yao Zi @ 2025-12-09 14:00 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
	Krzysztof Kozlowski, Conor Dooley, Huacai Chen, WANG Xuerui,
	Jiaxun Yang, Binbin Zhou
  Cc: linux-pci, devicetree, linux-kernel, loongarch, Yao Zi

Running dtbs_check with ARCH=loongarch emits a lot of warnings, most
about describing sideband interrupts for PCI devices through interrupts
property, and usage of undocumented msi-parent property in pcie
controller in loongson-2k2000.dtsi.

Patch 1 solves the former problem by using interrupts-extended property
for these devices. I don't have LS2K1000/2000 devices on hand, so
helping in testing it will be appreciated. msi-parent property is
documented in the second patch for Loongson PCI controllers.

After applying the series, the only two warnings left are about naming
of I2C controllers,

/builder/repo/linux/arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: i2c-gpio-0 (i2c-gpio): $nodename:0: 'i2c-gpio-0' does not match '^i2c(@.+|-[a-z0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
/builder/repo/linux/arch/loongarch/boot/dts/loongson-2k1000-ref.dtb: i2c-gpio-1 (i2c-gpio): $nodename:0: 'i2c-gpio-1' does not match '^i2c(@.+|-[a-z0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#

which IMHO is a regression caused by dt-schema commit 57138f5b8c92
("schemas: i2c: Avoid extra characters in i2c nodename pattern"). Commit
647181a1f8ff ("schemas: i2c: Allow for 'i2c-.*' node names") fails to
fix the case, as it doesn't take nodenames with multiple hyphens in
account. I'll start a separate series for this.

Thanks for your time and review.

Yao Zi (2):
  LoongArch: dts: Describe PCI sideband IRQ through interrupt-extended
  dt-bindings: PCI: loongson: Document msi-parent property

 .../devicetree/bindings/pci/loongson.yaml     |  2 ++
 arch/loongarch/boot/dts/loongson-2k1000.dtsi  | 25 ++++++---------
 arch/loongarch/boot/dts/loongson-2k2000.dtsi  | 32 +++++++------------
 3 files changed, 23 insertions(+), 36 deletions(-)

-- 
2.51.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property
  2025-12-09 14:00 [PATCH 0/2] Fix LoongArch dtbs_check warnings Yao Zi
@ 2025-12-09 14:00 ` Yao Zi
  2025-12-09 22:39   ` Rob Herring (Arm)
  0 siblings, 1 reply; 4+ messages in thread
From: Yao Zi @ 2025-12-09 14:00 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
	Krzysztof Kozlowski, Conor Dooley, Huacai Chen, WANG Xuerui,
	Jiaxun Yang, Binbin Zhou
  Cc: linux-pci, devicetree, linux-kernel, loongarch, Yao Zi

Loongson PCI controllers found in LS2K1000/2000 SoCs
(loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
controllers.

Though only the one in LS2K2000 SoC is described in devicetree, we
should document the property for all variants. For the same reason, it
isn't marked as required for now.

Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
Signed-off-by: Yao Zi <me@ziyao.cc>
---
 Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml
index e5bba63aa947..26e77218b901 100644
--- a/Documentation/devicetree/bindings/pci/loongson.yaml
+++ b/Documentation/devicetree/bindings/pci/loongson.yaml
@@ -32,6 +32,8 @@ properties:
     minItems: 1
     maxItems: 3
 
+  msi-parent: true
+
 required:
   - compatible
   - reg
-- 
2.51.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property
  2025-12-09 14:00 ` [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property Yao Zi
@ 2025-12-09 22:39   ` Rob Herring (Arm)
  2025-12-10  5:22     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-12-09 22:39 UTC (permalink / raw)
  To: Yao Zi
  Cc: linux-pci, Conor Dooley, Lorenzo Pieralisi,
	Krzysztof Wilczyński, linux-kernel, Jiaxun Yang, devicetree,
	Manivannan Sadhasivam, WANG Xuerui, Krzysztof Kozlowski,
	loongarch, Binbin Zhou, Bjorn Helgaas, Huacai Chen


On Tue, 09 Dec 2025 14:00:06 +0000, Yao Zi wrote:
> Loongson PCI controllers found in LS2K1000/2000 SoCs
> (loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
> RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
> controllers.
> 
> Though only the one in LS2K2000 SoC is described in devicetree, we
> should document the property for all variants. For the same reason, it
> isn't marked as required for now.
> 
> Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
> Signed-off-by: Yao Zi <me@ziyao.cc>
> ---
>  Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property
  2025-12-09 22:39   ` Rob Herring (Arm)
@ 2025-12-10  5:22     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-10  5:22 UTC (permalink / raw)
  To: Rob Herring (Arm), Yao Zi
  Cc: linux-pci, Conor Dooley, Lorenzo Pieralisi,
	Krzysztof Wilczyński, linux-kernel, Jiaxun Yang, devicetree,
	Manivannan Sadhasivam, WANG Xuerui, Krzysztof Kozlowski,
	loongarch, Binbin Zhou, Bjorn Helgaas, Huacai Chen

On 09/12/2025 23:39, Rob Herring (Arm) wrote:
> 
> On Tue, 09 Dec 2025 14:00:06 +0000, Yao Zi wrote:
>> Loongson PCI controllers found in LS2K1000/2000 SoCs
>> (loongson,ls2k-pci), 7A1000/2000 bridge chips (loongson,ls7a-pci), and
>> RS780E bridge chips (loongson,rs780e-pci) all have their paired MSI
>> controllers.
>>
>> Though only the one in LS2K2000 SoC is described in devicetree, we
>> should document the property for all variants. For the same reason, it
>> isn't marked as required for now.
>>
>> Fixes: 83e757ecfd5d ("dt-bindings: Document Loongson PCI Host Controller")
>> Signed-off-by: Yao Zi <me@ziyao.cc>
>> ---
>>  Documentation/devicetree/bindings/pci/loongson.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> 

Seems my explicit pointing towards Loongarch during OSS talk brought
some effects...

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-10  5:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-09 14:00 [PATCH 0/2] Fix LoongArch dtbs_check warnings Yao Zi
2025-12-09 14:00 ` [PATCH 2/2] dt-bindings: PCI: loongson: Document msi-parent property Yao Zi
2025-12-09 22:39   ` Rob Herring (Arm)
2025-12-10  5:22     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).