From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2697AC4338F for ; Tue, 3 Aug 2021 20:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0880A60EC0 for ; Tue, 3 Aug 2021 20:47:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbhHCUrY (ORCPT ); Tue, 3 Aug 2021 16:47:24 -0400 Received: from gloria.sntech.de ([185.11.138.130]:38932 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbhHCUrY (ORCPT ); Tue, 3 Aug 2021 16:47:24 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mB1Jb-0003eZ-Ux; Tue, 03 Aug 2021 22:47:07 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Riesch Cc: Rob Herring , Liang Chen , Peter Geis , Sascha Hauer , Michael Riesch , Simon Xue Subject: Re: [PATCH 4/5] arm64: dts: rockchip: rk3568-evb1-v10: add pinctrl and alias to emmc node Date: Tue, 03 Aug 2021 22:47:07 +0200 Message-ID: <4739137.8F6SAcFxjW@diego> In-Reply-To: <20210803185309.10013-5-michael.riesch@wolfvision.net> References: <20210803185309.10013-1-michael.riesch@wolfvision.net> <20210803185309.10013-5-michael.riesch@wolfvision.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 3. August 2021, 20:53:08 CEST schrieb Michael Riesch: > Signed-off-by: Michael Riesch > --- > arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > index f3fd4a6813a2..3ac70a8183c4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > @@ -16,6 +16,7 @@ > aliases { > ethernet0 = &gmac0; > ethernet1 = &gmac1; > + emmc = &sdhci; what is this supposed to do? I don't think "emmc" is defined as any form of alias, instead mmc aliases generally are more "mmcX" for X 0,1,etc . Heiko > }; > > chosen: chosen { > @@ -347,6 +348,8 @@ > bus-width = <8>; > max-frequency = <200000000>; > non-removable; > + pinctrl-names = "default"; > + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; > status = "okay"; > }; > >