Re: [PATCH v6 3/3] arm64: dts: qcom: sm8250: Add JPEG encoder node

["Gjorgji Rosikopulos (Consultant)" <gjorgji.rosikopulos@oss.qualcomm.com>]

Hi Atanas, Dmitry,

On 7/30/2026 9:02 PM, Atanas Filipov wrote:
> On 7/30/2026 7:01 PM, Dmitry Baryshkov wrote:
>> On Thu, Jul 30, 2026 at 06:05:24PM +0300, Atanas Filipov wrote:
>>> Add the JPEG encoder hardware node to the SM8250 device tree so the
>>> qcom-jpeg V4L2 encoder driver can bind and operate on this platform.
>>>
>>> Signed-off-by: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sm8250.dtsi | 72 ++++++++++++++++++++++++++++
>>>   1 file changed, 72 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>>> index f11da2ca4181..d42b29419320 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>>> @@ -13,6 +13,7 @@
>>>   #include <dt-bindings/firmware/qcom,scm.h>
>>>   #include <dt-bindings/gpio/gpio.h>
>>>   #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>> +#include <dt-bindings/interconnect/qcom,icc.h>
>>>   #include <dt-bindings/interconnect/qcom,sm8250.h>
>>>   #include <dt-bindings/mailbox/qcom-ipcc.h>
>>>   #include <dt-bindings/phy/phy-qcom-qmp.h>
>>> @@ -4486,6 +4487,77 @@ cci1_i2c1: i2c-bus@1 {
>>>   			};
>>>   		};
>>>   
>>> +		jpeg-encoder@ac53000 {
>>> +			compatible = "qcom,sm8250-jpeg-enc";
>>> +			status = "disabled";
>>> +
>>> +			reg = <0x0 0x0ac53000 0x0 0x1000>;
>>> +
>>> +			interrupts = <GIC_SPI 474 IRQ_TYPE_EDGE_RISING>;
>>> +
>>> +			power-domains = <&camcc TITAN_TOP_GDSC>,
>>> +					<&rpmhpd RPMHPD_MMCX>,
>>
>> Is TITAN_TOP a part of the MMCX or CX domain? In the former case,
>> please drop separate mmcx vote here and let it come through the
>> titan_top (it might require camcc driver and node modifications).
>>
> 
> The change was requested by Brian, most likely in connection with 
> upcoming migrations. I think he would be able to explain the exact 
> reasons. As far as the facts are concerned, this is not currently 
> necessary for the driver to be functional.

In the documentation we have this jpeg block need only TITAN_TOP_GDSC power domain.
However Bryan request to ad MMCX and MX.
As i can see same is for csiphy. Maybe is better to sync with Bryan.

Regards,
~Gjorgji