* [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
@ 2023-01-18 17:39 ` Krzysztof Kozlowski
2023-01-18 19:04 ` Geert Uytterhoeven
` (3 more replies)
2023-01-19 4:53 ` [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Andrew Jeffery
` (5 subsequent siblings)
6 siblings, 4 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-18 17:39 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
Cc: Krzysztof Kozlowski
Cleanup examples:
- use 4-space indentation (for cases when it is neither 4 not 2 space),
- drop redundant blank lines,
- use lowercase hex.
No functional impact except adjusting to preferred coding style.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/spi/amlogic,meson-gx-spicc.yaml | 26 +--
.../bindings/spi/amlogic,meson6-spifc.yaml | 22 +--
.../bindings/spi/aspeed,ast2600-fmc.yaml | 24 +--
.../bindings/spi/brcm,spi-bcm-qspi.yaml | 156 +++++++++---------
.../bindings/spi/cdns,qspi-nor.yaml | 4 +-
.../bindings/spi/nvidia,tegra210-quad.yaml | 42 ++---
.../bindings/spi/qcom,spi-qcom-qspi.yaml | 1 -
.../devicetree/bindings/spi/renesas,rspi.yaml | 22 +--
.../bindings/spi/spi-sunplus-sp7021.yaml | 4 +-
.../devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
10 files changed, 150 insertions(+), 152 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
index e5eca3a6f132..4e28e6e9d8e0 100644
--- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
+++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
@@ -100,17 +100,17 @@ unevaluatedProperties: false
examples:
- |
spi@c1108d80 {
- compatible = "amlogic,meson-gx-spicc";
- reg = <0xc1108d80 0x80>;
- interrupts = <112>;
- clocks = <&clk81>;
- clock-names = "core";
- #address-cells = <1>;
- #size-cells = <0>;
-
- display@0 {
- compatible = "lg,lg4573";
- spi-max-frequency = <1000000>;
- reg = <0>;
- };
+ compatible = "amlogic,meson-gx-spicc";
+ reg = <0xc1108d80 0x80>;
+ interrupts = <112>;
+ clocks = <&clk81>;
+ clock-names = "core";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ display@0 {
+ compatible = "lg,lg4573";
+ spi-max-frequency = <1000000>;
+ reg = <0>;
+ };
};
diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
index 806043fed4d1..8e769ccda97f 100644
--- a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
+++ b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
@@ -40,15 +40,15 @@ unevaluatedProperties: false
examples:
- |
spi@c1108c80 {
- compatible = "amlogic,meson6-spifc";
- reg = <0xc1108c80 0x80>;
- clocks = <&clk81>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- flash: flash@0 {
- compatible = "spansion,m25p80", "jedec,spi-nor";
- reg = <0>;
- spi-max-frequency = <40000000>;
- };
+ compatible = "amlogic,meson6-spifc";
+ reg = <0xc1108c80 0x80>;
+ clocks = <&clk81>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ flash: flash@0 {
+ compatible = "spansion,m25p80", "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <40000000>;
+ };
};
diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
index aae6fb139b5b..57d932af4506 100644
--- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
+++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
@@ -60,23 +60,23 @@ examples:
interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
flash@0 {
- reg = < 0 >;
- compatible = "jedec,spi-nor";
- spi-max-frequency = <50000000>;
- spi-rx-bus-width = <2>;
+ reg = < 0 >;
+ compatible = "jedec,spi-nor";
+ spi-max-frequency = <50000000>;
+ spi-rx-bus-width = <2>;
};
flash@1 {
- reg = < 1 >;
- compatible = "jedec,spi-nor";
- spi-max-frequency = <50000000>;
- spi-rx-bus-width = <2>;
+ reg = < 1 >;
+ compatible = "jedec,spi-nor";
+ spi-max-frequency = <50000000>;
+ spi-rx-bus-width = <2>;
};
flash@2 {
- reg = < 2 >;
- compatible = "jedec,spi-nor";
- spi-max-frequency = <50000000>;
- spi-rx-bus-width = <2>;
+ reg = < 2 >;
+ compatible = "jedec,spi-nor";
+ spi-max-frequency = <50000000>;
+ spi-rx-bus-width = <2>;
};
};
diff --git a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
index ec5873919170..28222aae3077 100644
--- a/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/brcm,spi-bcm-qspi.yaml
@@ -99,98 +99,98 @@ required:
examples:
- | # BRCMSTB SoC: SPI Master (MSPI+BSPI) for SPI-NOR access
spi@f03e3400 {
- compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi";
- reg = <0xf03e3400 0x188>, <0xf03e3200 0x50>, <0xf03e0920 0x4>;
- reg-names = "mspi", "bspi", "cs_reg";
- interrupts = <0x5>, <0x6>, <0x1>, <0x2>, <0x3>, <0x4>, <0x0>;
- interrupt-parent = <&gic>;
- interrupt-names = "mspi_done",
- "mspi_halted",
- "spi_lr_fullness_reached",
- "spi_lr_session_aborted",
- "spi_lr_impatient",
- "spi_lr_session_done",
- "spi_lr_overread";
- clocks = <&hif_spi>;
- #address-cells = <0x1>;
- #size-cells = <0x0>;
-
- flash@0 {
- #size-cells = <0x2>;
- #address-cells = <0x2>;
- compatible = "m25p80";
- reg = <0x0>;
- spi-max-frequency = <0x2625a00>;
- spi-cpol;
- spi-cpha;
- };
+ compatible = "brcm,spi-brcmstb-qspi", "brcm,spi-bcm-qspi";
+ reg = <0xf03e3400 0x188>, <0xf03e3200 0x50>, <0xf03e0920 0x4>;
+ reg-names = "mspi", "bspi", "cs_reg";
+ interrupts = <0x5>, <0x6>, <0x1>, <0x2>, <0x3>, <0x4>, <0x0>;
+ interrupt-parent = <&gic>;
+ interrupt-names = "mspi_done",
+ "mspi_halted",
+ "spi_lr_fullness_reached",
+ "spi_lr_session_aborted",
+ "spi_lr_impatient",
+ "spi_lr_session_done",
+ "spi_lr_overread";
+ clocks = <&hif_spi>;
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ flash@0 {
+ #size-cells = <0x2>;
+ #address-cells = <0x2>;
+ compatible = "m25p80";
+ reg = <0x0>;
+ spi-max-frequency = <0x2625a00>;
+ spi-cpol;
+ spi-cpha;
+ };
};
- | # BRCMSTB SoC: MSPI master for any SPI device
spi@f0416000 {
- clocks = <&upg_fixed>;
- compatible = "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi";
- reg = <0xf0416000 0x180>;
- reg-names = "mspi";
- interrupts = <0x14>;
- interrupt-parent = <&irq0_aon_intc>;
- interrupt-names = "mspi_done";
- #address-cells = <1>;
- #size-cells = <0>;
+ clocks = <&upg_fixed>;
+ compatible = "brcm,spi-brcmstb-mspi", "brcm,spi-bcm-qspi";
+ reg = <0xf0416000 0x180>;
+ reg-names = "mspi";
+ interrupts = <0x14>;
+ interrupt-parent = <&irq0_aon_intc>;
+ interrupt-names = "mspi_done";
+ #address-cells = <1>;
+ #size-cells = <0>;
};
- | # iProc SoC
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
spi@18027200 {
- compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
- reg = <0x18027200 0x184>,
- <0x18027000 0x124>,
- <0x1811c408 0x004>,
- <0x180273a0 0x01c>;
- reg-names = "mspi", "bspi", "intr_regs", "intr_status_reg";
- interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "mspi_done",
- "mspi_halted",
- "spi_lr_fullness_reached",
- "spi_lr_session_aborted",
- "spi_lr_impatient",
- "spi_lr_session_done";
- clocks = <&iprocmed>;
- num-cs = <2>;
- #address-cells = <1>;
- #size-cells = <0>;
+ compatible = "brcm,spi-nsp-qspi", "brcm,spi-bcm-qspi";
+ reg = <0x18027200 0x184>,
+ <0x18027000 0x124>,
+ <0x1811c408 0x004>,
+ <0x180273a0 0x01c>;
+ reg-names = "mspi", "bspi", "intr_regs", "intr_status_reg";
+ interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "mspi_done",
+ "mspi_halted",
+ "spi_lr_fullness_reached",
+ "spi_lr_session_aborted",
+ "spi_lr_impatient",
+ "spi_lr_session_done";
+ clocks = <&iprocmed>;
+ num-cs = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
- | # NS2 SoC
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
spi@66470200 {
- compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
- reg = <0x66470200 0x184>,
- <0x66470000 0x124>,
- <0x67017408 0x004>,
- <0x664703a0 0x01c>;
- reg-names = "mspi", "bspi", "intr_regs", "intr_status_reg";
- interrupts = <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "spi_l1_intr";
- clocks = <&iprocmed>;
- num-cs = <2>;
+ compatible = "brcm,spi-ns2-qspi", "brcm,spi-bcm-qspi";
+ reg = <0x66470200 0x184>,
+ <0x66470000 0x124>,
+ <0x67017408 0x004>,
+ <0x664703a0 0x01c>;
+ reg-names = "mspi", "bspi", "intr_regs", "intr_status_reg";
+ interrupts = <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "spi_l1_intr";
+ clocks = <&iprocmed>;
+ num-cs = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ flash@0 {
#address-cells = <1>;
- #size-cells = <0>;
-
- flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "m25p80";
- reg = <0x0>;
- spi-max-frequency = <12500000>;
- spi-cpol;
- spi-cpha;
- };
+ #size-cells = <1>;
+ compatible = "m25p80";
+ reg = <0x0>;
+ spi-max-frequency = <12500000>;
+ spi-cpol;
+ spi-cpha;
+ };
};
diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index 9be4e2c5d1ee..7606b5a252b6 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -117,7 +117,7 @@ examples:
reset-names = "qspi", "qspi-ocp";
flash@0 {
- compatible = "jedec,spi-nor";
- reg = <0x0>;
+ compatible = "jedec,spi-nor";
+ reg = <0x0>;
};
};
diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
index 9f78b2c06494..9ae1611175f2 100644
--- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
+++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
@@ -74,25 +74,25 @@ examples:
#include <dt-bindings/reset/tegra210-car.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
spi@70410000 {
- compatible = "nvidia,tegra210-qspi";
- reg = <0x70410000 0x1000>;
- interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
- clocks = <&tegra_car TEGRA210_CLK_QSPI>,
- <&tegra_car TEGRA210_CLK_QSPI_PM>;
- clock-names = "qspi", "qspi_out";
- resets = <&tegra_car 211>;
- dmas = <&apbdma 5>, <&apbdma 5>;
- dma-names = "rx", "tx";
-
- flash@0 {
- compatible = "jedec,spi-nor";
- reg = <0>;
- spi-max-frequency = <104000000>;
- spi-tx-bus-width = <2>;
- spi-rx-bus-width = <2>;
- nvidia,tx-clk-tap-delay = <0>;
- nvidia,rx-clk-tap-delay = <0>;
- };
+ compatible = "nvidia,tegra210-qspi";
+ reg = <0x70410000 0x1000>;
+ interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&tegra_car TEGRA210_CLK_QSPI>,
+ <&tegra_car TEGRA210_CLK_QSPI_PM>;
+ clock-names = "qspi", "qspi_out";
+ resets = <&tegra_car 211>;
+ dmas = <&apbdma 5>, <&apbdma 5>;
+ dma-names = "rx", "tx";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <104000000>;
+ spi-tx-bus-width = <2>;
+ spi-rx-bus-width = <2>;
+ nvidia,tx-clk-tap-delay = <0>;
+ nvidia,rx-clk-tap-delay = <0>;
+ };
};
diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
index 85e7770703bd..e94d915e28c8 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
@@ -87,7 +87,6 @@ examples:
spi-tx-bus-width = <2>;
spi-rx-bus-width = <2>;
};
-
};
};
...
diff --git a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
index f45d3b75d6de..4d8ec69214c9 100644
--- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
+++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
@@ -141,15 +141,15 @@ examples:
#include <dt-bindings/power/r8a7791-sysc.h>
qspi: spi@e6b10000 {
- compatible = "renesas,qspi-r8a7791", "renesas,qspi";
- reg = <0xe6b10000 0x2c>;
- interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 917>;
- dmas = <&dmac0 0x17>, <&dmac0 0x18>, <&dmac1 0x17>, <&dmac1 0x18>;
- dma-names = "tx", "rx", "tx", "rx";
- power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
- resets = <&cpg 917>;
- num-cs = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
+ compatible = "renesas,qspi-r8a7791", "renesas,qspi";
+ reg = <0xe6b10000 0x2c>;
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 917>;
+ dmas = <&dmac0 0x17>, <&dmac0 0x18>, <&dmac1 0x17>, <&dmac1 0x18>;
+ dma-names = "tx", "rx", "tx", "rx";
+ power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
+ resets = <&cpg 917>;
+ num-cs = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
};
diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
index 69a463305274..edb5ba71af3a 100644
--- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
@@ -59,9 +59,9 @@ unevaluatedProperties: false
examples:
- |
#include <dt-bindings/interrupt-controller/irq.h>
- spi@9C002D80 {
+ spi@9c002d80 {
compatible = "sunplus,sp7021-spi";
- reg = <0x9C002D80 0x80>, <0x9C002E00 0x80>;
+ reg = <0x9c002d80 0x80>, <0x9c002e00 0x80>;
reg-names = "master", "slave";
interrupt-parent = <&intc>;
interrupt-names = "dma_w",
diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
index d35c6f7e2dd5..18afdaab946d 100644
--- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
@@ -95,7 +95,6 @@ examples:
<&dmamux1 1 40 0x400 0x05>;
dma-names = "rx", "tx";
cs-gpios = <&gpioa 11 0>;
-
};
...
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
@ 2023-01-18 19:04 ` Geert Uytterhoeven
2023-01-19 4:44 ` Andrew Jeffery
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2023-01-18 19:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Brown, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, ‚ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On Wed, Jan 18, 2023 at 6:39 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Cleanup examples:
> - use 4-space indentation (for cases when it is neither 4 not 2 space),
> - drop redundant blank lines,
> - use lowercase hex.
>
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> .../devicetree/bindings/spi/renesas,rspi.yaml | 22 +--
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
2023-01-18 19:04 ` Geert Uytterhoeven
@ 2023-01-19 4:44 ` Andrew Jeffery
2023-01-19 7:21 ` Neil Armstrong
2023-01-23 20:17 ` Rob Herring
3 siblings, 0 replies; 13+ messages in thread
From: Andrew Jeffery @ 2023-01-19 4:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
open list:SPI SUBSYSTEM, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On Thu, 19 Jan 2023, at 04:09, Krzysztof Kozlowski wrote:
> Cleanup examples:
> - use 4-space indentation (for cases when it is neither 4 not 2 space),
> - drop redundant blank lines,
> - use lowercase hex.
>
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 26 +--
> .../bindings/spi/amlogic,meson6-spifc.yaml | 22 +--
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 24 +--
For the Aspeed change:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
2023-01-18 19:04 ` Geert Uytterhoeven
2023-01-19 4:44 ` Andrew Jeffery
@ 2023-01-19 7:21 ` Neil Armstrong
2023-01-23 20:17 ` Rob Herring
3 siblings, 0 replies; 13+ messages in thread
From: Neil Armstrong @ 2023-01-19 7:21 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On 18/01/2023 18:39, Krzysztof Kozlowski wrote:
> Cleanup examples:
> - use 4-space indentation (for cases when it is neither 4 not 2 space),
> - drop redundant blank lines,
> - use lowercase hex.
>
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 26 +--
> .../bindings/spi/amlogic,meson6-spifc.yaml | 22 +--
For meson changes:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 24 +--
> .../bindings/spi/brcm,spi-bcm-qspi.yaml | 156 +++++++++---------
> .../bindings/spi/cdns,qspi-nor.yaml | 4 +-
> .../bindings/spi/nvidia,tegra210-quad.yaml | 42 ++---
> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 1 -
> .../devicetree/bindings/spi/renesas,rspi.yaml | 22 +--
> .../bindings/spi/spi-sunplus-sp7021.yaml | 4 +-
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
> 10 files changed, 150 insertions(+), 152 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> index e5eca3a6f132..4e28e6e9d8e0 100644
> --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> @@ -100,17 +100,17 @@ unevaluatedProperties: false
> examples:
> - |
> spi@c1108d80 {
> - compatible = "amlogic,meson-gx-spicc";
> - reg = <0xc1108d80 0x80>;
> - interrupts = <112>;
> - clocks = <&clk81>;
> - clock-names = "core";
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - display@0 {
> - compatible = "lg,lg4573";
> - spi-max-frequency = <1000000>;
> - reg = <0>;
> - };
> + compatible = "amlogic,meson-gx-spicc";
> + reg = <0xc1108d80 0x80>;
> + interrupts = <112>;
> + clocks = <&clk81>;
> + clock-names = "core";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + display@0 {
> + compatible = "lg,lg4573";
> + spi-max-frequency = <1000000>;
> + reg = <0>;
> + };
> };
> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> index 806043fed4d1..8e769ccda97f 100644
> --- a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> @@ -40,15 +40,15 @@ unevaluatedProperties: false
> examples:
> - |
> spi@c1108c80 {
> - compatible = "amlogic,meson6-spifc";
> - reg = <0xc1108c80 0x80>;
> - clocks = <&clk81>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - flash: flash@0 {
> - compatible = "spansion,m25p80", "jedec,spi-nor";
> - reg = <0>;
> - spi-max-frequency = <40000000>;
> - };
> + compatible = "amlogic,meson6-spifc";
> + reg = <0xc1108c80 0x80>;
> + clocks = <&clk81>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + flash: flash@0 {
> + compatible = "spansion,m25p80", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <40000000>;
> + };
> };
<snip>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-19 7:21 ` Neil Armstrong
@ 2023-01-23 20:17 ` Rob Herring
2023-01-24 8:17 ` Krzysztof Kozlowski
3 siblings, 1 reply; 13+ messages in thread
From: Rob Herring @ 2023-01-23 20:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Brown, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Chin-Ting Kuo, Cédric Le Goater,
Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On Wed, Jan 18, 2023 at 06:39:32PM +0100, Krzysztof Kozlowski wrote:
> Cleanup examples:
> - use 4-space indentation (for cases when it is neither 4 not 2 space),
> - drop redundant blank lines,
> - use lowercase hex.
>
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 26 +--
> .../bindings/spi/amlogic,meson6-spifc.yaml | 22 +--
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 24 +--
> .../bindings/spi/brcm,spi-bcm-qspi.yaml | 156 +++++++++---------
> .../bindings/spi/cdns,qspi-nor.yaml | 4 +-
> .../bindings/spi/nvidia,tegra210-quad.yaml | 42 ++---
> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 1 -
> .../devicetree/bindings/spi/renesas,rspi.yaml | 22 +--
> .../bindings/spi/spi-sunplus-sp7021.yaml | 4 +-
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
> 10 files changed, 150 insertions(+), 152 deletions(-)
[...]
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> index d35c6f7e2dd5..18afdaab946d 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
> @@ -95,7 +95,6 @@ examples:
> <&dmamux1 1 40 0x400 0x05>;
> dma-names = "rx", "tx";
> cs-gpios = <&gpioa 11 0>;
Looks like the indentation needs adjusting here.
> -
> };
>
> ...
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex
2023-01-23 20:17 ` Rob Herring
@ 2023-01-24 8:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-24 8:17 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Brown, Krzysztof Kozlowski, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl, Chin-Ting Kuo, Cédric Le Goater,
Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On 23/01/2023 21:17, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 06:39:32PM +0100, Krzysztof Kozlowski wrote:
>> Cleanup examples:
>> - use 4-space indentation (for cases when it is neither 4 not 2 space),
>> - drop redundant blank lines,
>> - use lowercase hex.
>>
>> No functional impact except adjusting to preferred coding style.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 26 +--
>> .../bindings/spi/amlogic,meson6-spifc.yaml | 22 +--
>> .../bindings/spi/aspeed,ast2600-fmc.yaml | 24 +--
>> .../bindings/spi/brcm,spi-bcm-qspi.yaml | 156 +++++++++---------
>> .../bindings/spi/cdns,qspi-nor.yaml | 4 +-
>> .../bindings/spi/nvidia,tegra210-quad.yaml | 42 ++---
>> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 1 -
>> .../devicetree/bindings/spi/renesas,rspi.yaml | 22 +--
>> .../bindings/spi/spi-sunplus-sp7021.yaml | 4 +-
>> .../devicetree/bindings/spi/st,stm32-spi.yaml | 1 -
>> 10 files changed, 150 insertions(+), 152 deletions(-)
>
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
>> index d35c6f7e2dd5..18afdaab946d 100644
>> --- a/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/st,stm32-spi.yaml
>> @@ -95,7 +95,6 @@ examples:
>> <&dmamux1 1 40 0x400 0x05>;
>> dma-names = "rx", "tx";
>> cs-gpios = <&gpioa 11 0>;
>
> Looks like the indentation needs adjusting here.
>
Ack
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
@ 2023-01-19 4:53 ` Andrew Jeffery
2023-01-19 7:20 ` Neil Armstrong
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Andrew Jeffery @ 2023-01-19 4:53 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
open list:SPI SUBSYSTEM, devicetree, linux-arm-kernel,
linux-sunxi, linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On Thu, 19 Jan 2023, at 04:09, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 +-
> .../bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 +-
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 6 +++---
> .../bindings/spi/amlogic,meson6-spifc.yaml | 6 +++---
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 2 +-
For the Aspeed change:
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
2023-01-18 17:39 ` [PATCH 2/2] spi: dt-bindings: cleanup examples - indentation, lowercase hex Krzysztof Kozlowski
2023-01-19 4:53 ` [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Andrew Jeffery
@ 2023-01-19 7:20 ` Neil Armstrong
2023-01-19 7:41 ` Patrice CHOTARD
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Neil Armstrong @ 2023-01-19 7:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Patrice Chotard, Erwan Leray, Fabrice Gasnier,
linux-spi, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel, linux-amlogic, linux-aspeed, openbmc,
linux-mediatek, linux-tegra, linux-arm-msm, linux-rockchip,
linux-riscv, linux-stm32
On 18/01/2023 18:39, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 +-
> .../bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 +-
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 6 +++---
> .../bindings/spi/amlogic,meson6-spifc.yaml | 6 +++---
For meson changes:
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 2 +-
> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 2 +-
> .../devicetree/bindings/spi/cdns,xspi.yaml | 6 +++---
> .../bindings/spi/fsl,spi-fsl-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/fsl-imx-cspi.yaml | 2 +-
> .../bindings/spi/mediatek,spi-mt65xx.yaml | 2 +-
> .../spi/mediatek,spi-slave-mt27xx.yaml | 2 +-
> .../bindings/spi/mikrotik,rb4xx-spi.yaml | 2 +-
> .../bindings/spi/mxicy,mx25f0a-spi.yaml | 2 +-
> .../devicetree/bindings/spi/mxs-spi.yaml | 2 +-
> .../bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++---
> .../bindings/spi/realtek,rtl-spi.yaml | 2 +-
> .../bindings/spi/snps,dw-apb-ssi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-cadence.yaml | 2 +-
> .../devicetree/bindings/spi/spi-fsl-lpspi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-gpio.yaml | 4 ++--
> .../devicetree/bindings/spi/spi-mux.yaml | 4 ++--
> .../devicetree/bindings/spi/spi-nxp-fspi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-pl022.yaml | 18 +++++++++---------
> .../devicetree/bindings/spi/spi-rockchip.yaml | 2 +-
> .../devicetree/bindings/spi/spi-sifive.yaml | 6 +++---
> .../bindings/spi/spi-sunplus-sp7021.yaml | 2 +-
> .../devicetree/bindings/spi/spi-xilinx.yaml | 2 +-
> .../bindings/spi/spi-zynqmp-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/sprd,spi-adi.yaml | 5 ++---
> .../devicetree/bindings/spi/st,stm32-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 2 +-
> .../bindings/spi/xlnx,zynq-qspi.yaml | 2 +-
> 33 files changed, 53 insertions(+), 55 deletions(-)
>
<snip>
> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> index 53eb6562b979..e5eca3a6f132 100644
> --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml
> @@ -2,8 +2,8 @@
> # Copyright 2019 BayLibre, SAS
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/spi/amlogic,meson-gx-spicc.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/spi/amlogic,meson-gx-spicc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Amlogic Meson SPI Communication Controller
>
> @@ -41,7 +41,7 @@ properties:
> maxItems: 2
>
> allOf:
> - - $ref: "spi-controller.yaml#"
> + - $ref: spi-controller.yaml#
> - if:
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> index ac3b2ec300ac..806043fed4d1 100644
> --- a/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson6-spifc.yaml
> @@ -2,8 +2,8 @@
> # Copyright 2019 BayLibre, SAS
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/spi/amlogic,meson6-spifc.yaml#"
> -$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +$id: http://devicetree.org/schemas/spi/amlogic,meson6-spifc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Amlogic Meson SPI Flash Controller
>
> @@ -11,7 +11,7 @@ maintainers:
> - Neil Armstrong <neil.armstrong@linaro.org>
>
> allOf:
> - - $ref: "spi-controller.yaml#"
> + - $ref: spi-controller.yaml#
>
> description: |
> The Meson SPIFC is a controller optimized for communication with SPI
<snip>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-19 7:20 ` Neil Armstrong
@ 2023-01-19 7:41 ` Patrice CHOTARD
2023-01-19 12:27 ` Heiko Stuebner
` (2 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Patrice CHOTARD @ 2023-01-19 7:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Heiko Stuebner,
Palmer Dabbelt, Paul Walmsley, Li-hao Kuo, Michal Simek,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Maxime Ripard, �ecki, Vaishnav Achath,
Parshuram Thombare, Leilk Liu, Gabor Juhos, Bert Vermeulen,
Miquel Raynal, Marek Vasut, Birger Koblitz, Geert Uytterhoeven,
Anson Huang, Chris Packham, Kuldeep Singh, Pragnesh Patel,
Christophe Kerello, Erwan Leray, Fabrice Gasnier, linux-spi,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-amlogic, linux-aspeed, openbmc, linux-mediatek, linux-tegra,
linux-arm-msm, linux-rockchip, linux-riscv, linux-stm32
Hi Krzysztof
On 1/18/23 18:39, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
[...]
> diff --git a/Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml b/Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml
> index 1eb17f7a4d86..8bba965a9ae6 100644
> --- a/Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml
> @@ -11,7 +11,7 @@ maintainers:
> - Patrice Chotard <patrice.chotard@foss.st.com>
>
> allOf:
> - - $ref: "spi-controller.yaml#"
> + - $ref: spi-controller.yaml#
>
> properties:
> compatible:
For stm32-qspi
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-01-19 7:41 ` Patrice CHOTARD
@ 2023-01-19 12:27 ` Heiko Stuebner
2023-01-19 16:24 ` Serge Semin
2023-01-23 20:15 ` Rob Herring
6 siblings, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2023-01-19 12:27 UTC (permalink / raw)
To: Mark Brown, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Serge Semin,
Haibo Chen, Yogesh Gaur, Linus Walleij, Palmer Dabbelt,
Paul Walmsley, Li-hao Kuo, Michal Simek, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue, Maxime Ripard,
�ecki, Vaishnav Achath, Parshuram Thombare, Leilk Liu,
Gabor Juhos, Bert Vermeulen, Miquel Raynal, Marek Vasut,
Birger Koblitz, Geert Uytterhoeven, Anson Huang, Chris Packham,
Kuldeep Singh, Pragnesh Patel, Christophe Kerello,
Patrice Chotard, Erwan Leray, Fabrice Gasnier, linux-spi,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-amlogic, linux-aspeed, openbmc, linux-mediatek, linux-tegra,
linux-arm-msm, linux-rockchip, linux-riscv, linux-stm32,
Krzysztof Kozlowski
Cc: Krzysztof Kozlowski
Am Mittwoch, 18. Januar 2023, 18:39:31 CET schrieb Krzysztof Kozlowski:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
[...]
> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> index 66e49947b703..e4941e9212d1 100644
> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> @@ -11,7 +11,7 @@ description:
> as flash and display controllers using the SPI communication interface.
>
> allOf:
> - - $ref: "spi-controller.yaml#"
> + - $ref: spi-controller.yaml#
>
> maintainers:
> - Heiko Stuebner <heiko@sntech.de>
For Rockchip:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-01-19 12:27 ` Heiko Stuebner
@ 2023-01-19 16:24 ` Serge Semin
2023-01-23 20:15 ` Rob Herring
6 siblings, 0 replies; 13+ messages in thread
From: Serge Semin @ 2023-01-19 16:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Brown, Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Chin-Ting Kuo,
Cédric Le Goater, Joel Stanley, Andrew Jeffery, Kamal Dasu,
Broadcom internal kernel review list, Han Xu, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Matthias Brugger, Thierry Reding, Jonathan Hunter,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Haibo Chen,
Yogesh Gaur, Linus Walleij, Heiko Stuebner, Palmer Dabbelt,
Paul Walmsley, Li-hao Kuo, Michal Simek, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue, Maxime Ripard,
�ecki, Vaishnav Achath, Parshuram Thombare, Leilk Liu,
Gabor Juhos, Bert Vermeulen, Miquel Raynal, Marek Vasut,
Birger Koblitz, Geert Uytterhoeven, Anson Huang, Chris Packham,
Kuldeep Singh, Pragnesh Patel, Christophe Kerello,
Patrice Chotard, Erwan Leray, Fabrice Gasnier, linux-spi,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-amlogic, linux-aspeed, openbmc, linux-mediatek, linux-tegra,
linux-arm-msm, linux-rockchip, linux-riscv, linux-stm32
On Wed, Jan 18, 2023 at 06:39:31PM +0100, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
[nip]
> .../bindings/spi/snps,dw-apb-ssi.yaml | 2 +-
[nip]
> diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> index d33b72fabc5d..a132b5fc56e0 100644
> --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
> @@ -10,7 +10,7 @@ maintainers:
> - Mark Brown <broonie@kernel.org>
>
> allOf:
> - - $ref: "spi-controller.yaml#"
> + - $ref: spi-controller.yaml#
> - if:
> properties:
> compatible:
For the Synopsys DW SSI bindings:
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Thanks
-Serge(y)
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/2] spi: dt-bindings: drop unneeded quotes
2023-01-18 17:39 [PATCH 1/2] spi: dt-bindings: drop unneeded quotes Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-01-19 16:24 ` Serge Semin
@ 2023-01-23 20:15 ` Rob Herring
6 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2023-01-23 20:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jernej Skrabec, Neil Armstrong, Yogesh Gaur, Orson Zhai,
Leilk Liu, Bert Vermeulen, Patrice Chotard, Fabrice Gasnier,
Alexandre Torgue, linux-arm-kernel, Jerome Brunet, �ecki,
Samuel Holland, linux-rockchip, Maxime Coquelin, Anson Huang,
Kamal Dasu, linux-sunxi, Palmer Dabbelt, NXP Linux Team,
Krzysztof Kozlowski, Martin Blumenstingl, Han Xu, Birger Koblitz,
Andy Gross, Geert Uytterhoeven, Chunyan Zhang, Konrad Dybcio,
linux-riscv, Kevin Hilman, Joel Stanley, Chin-Ting Kuo, openbmc,
linux-mediatek, linux-spi, Andrew Jeffery,
Broadcom internal kernel review list, Fabio Estevam, Li-hao Kuo,
Michal Simek, Chris Packham, Erwan Leray, Marek Vasut,
Paul Walmsley, linux-aspeed, Parshuram Thombare, linux-amlogic,
Serge Semin, linux-tegra, Haibo Chen, Gabor Juhos,
Christophe Kerello, Maxime Ripard, Shawn Guo, Pragnesh Patel,
Kuldeep Singh, linux-stm32, devicetree, linux-kernel,
Cédric Le Goater, Sascha Hauer, Rob Herring, Chen-Yu Tsai,
Miquel Raynal, Jonathan Hunter, Mark Brown, Matthias Brugger,
Vaishnav Achath, Thierry Reding, linux-arm-msm, Baolin Wang,
Linus Walleij, Heiko Stuebner, Pengutronix Kernel Team,
Bjorn Andersson
On Wed, 18 Jan 2023 18:39:31 +0100, Krzysztof Kozlowski wrote:
> Cleanup by removing unneeded quotes from refs and redundant blank lines.
> No functional impact except adjusting to preferred coding style.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/allwinner,sun4i-a10-spi.yaml | 2 +-
> .../bindings/spi/allwinner,sun6i-a31-spi.yaml | 2 +-
> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 6 +++---
> .../bindings/spi/amlogic,meson6-spifc.yaml | 6 +++---
> .../bindings/spi/aspeed,ast2600-fmc.yaml | 2 +-
> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 2 +-
> .../devicetree/bindings/spi/cdns,xspi.yaml | 6 +++---
> .../bindings/spi/fsl,spi-fsl-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/fsl-imx-cspi.yaml | 2 +-
> .../bindings/spi/mediatek,spi-mt65xx.yaml | 2 +-
> .../spi/mediatek,spi-slave-mt27xx.yaml | 2 +-
> .../bindings/spi/mikrotik,rb4xx-spi.yaml | 2 +-
> .../bindings/spi/mxicy,mx25f0a-spi.yaml | 2 +-
> .../devicetree/bindings/spi/mxs-spi.yaml | 2 +-
> .../bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
> .../bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++---
> .../bindings/spi/realtek,rtl-spi.yaml | 2 +-
> .../bindings/spi/snps,dw-apb-ssi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-cadence.yaml | 2 +-
> .../devicetree/bindings/spi/spi-fsl-lpspi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-gpio.yaml | 4 ++--
> .../devicetree/bindings/spi/spi-mux.yaml | 4 ++--
> .../devicetree/bindings/spi/spi-nxp-fspi.yaml | 2 +-
> .../devicetree/bindings/spi/spi-pl022.yaml | 18 +++++++++---------
> .../devicetree/bindings/spi/spi-rockchip.yaml | 2 +-
> .../devicetree/bindings/spi/spi-sifive.yaml | 6 +++---
> .../bindings/spi/spi-sunplus-sp7021.yaml | 2 +-
> .../devicetree/bindings/spi/spi-xilinx.yaml | 2 +-
> .../bindings/spi/spi-zynqmp-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/sprd,spi-adi.yaml | 5 ++---
> .../devicetree/bindings/spi/st,stm32-qspi.yaml | 2 +-
> .../devicetree/bindings/spi/st,stm32-spi.yaml | 2 +-
> .../bindings/spi/xlnx,zynq-qspi.yaml | 2 +-
> 33 files changed, 53 insertions(+), 55 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread