From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 26/30] dt-bindings: pci: tegra: Document nvidia,plat-gpios optional prop References: <20190411170355.6882-1-mmaddireddy@nvidia.com> <20190411170355.6882-27-mmaddireddy@nvidia.com> <20190411201813.GT256045@google.com> From: Manikanta Maddireddy Message-ID: <477907b6-deb5-0a0f-19af-9b68dc9bf71b@nvidia.com> Date: Fri, 12 Apr 2019 12:31:40 +0530 MIME-Version: 1.0 In-Reply-To: <20190411201813.GT256045@google.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US To: Bjorn Helgaas Cc: thierry.reding@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, jonathanh@nvidia.com, lorenzo.pieralisi@arm.com, vidyas@nvidia.com, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org List-ID: On 12-Apr-19 1:48 AM, Bjorn Helgaas wrote: > On Thu, Apr 11, 2019 at 10:33:51PM +0530, Manikanta Maddireddy wrote: >> Document "nvidia,plat-gpios" optional property which supports configuring >> of platform specific gpios. > s/gpios/GPIOs/ (also in the description below) > > Acronyms in commit logs, comments, printks, etc should be capitalized. I will take care of it in next version. > >> Signed-off-by: Manikanta Maddireddy >> --- >> Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt >> index fbbd3bcb3435..dca8393b86d1 100644 >> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt >> @@ -73,6 +73,8 @@ Optional properties: >> pinctrl phandle to allow driver to explicitly put PCIe IO in DPD state. >> - pinctrl-1: PCIe IO(bias & REFCLK) deep power down(DPD) enable state. >> Pass pinctrl phandle to allow driver bring PCIe IO out of DPD state. >> +- nvidia,plat-gpios: A list of platform specific gpios which controls >> + endpoint's internal regulator or PCIe logic. >> >> Required properties on Tegra124 and later (deprecated): >> - phys: Must contain an entry for each entry in phy-names. >> @@ -567,6 +569,7 @@ Board DTS: >> pci@2,0 { >> phys = <&{/padctl@7009f000/pads/pcie/lanes/pcie-4}>; >> phy-names = "pcie-0"; >> + nvidia,plat-gpios = <&gpio TEGRA_GPIO(X, 3) GPIO_ACTIVE_HIGH>; >> status = "okay"; >> }; >> }; >> -- >> 2.17.1 >>