devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible
@ 2023-09-26 19:44 Tim Harvey
  2023-09-26 19:52 ` Ahmad Fatoum
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Harvey @ 2023-09-26 19:44 UTC (permalink / raw)
  To: Shawn Guo, devicetree, linux-arm-kernel, linux-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Tim Harvey

Fix the imx8mm-venice-gw72xx-0x-rpidsi dt overlay compatible string
which should be gw,imx8mm-gw72xx-0x.

Fixes: 6b4da1354fd8 ("arm64: dts: imx8mm: add imx8mm-venice-gw72xx-0x-rpidsi overlay for display")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
index e0768d408c3b..2e4156b58108 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
@@ -11,7 +11,7 @@
 /plugin/;
 
 &{/} {
-	compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm";
+	compatible = "gw,imx8mm-gw72xx-0x", "fsl,imx8mm";
 
 	panel {
 		compatible = "powertip,ph800480t013-idf02";
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible
  2023-09-26 19:44 [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible Tim Harvey
@ 2023-09-26 19:52 ` Ahmad Fatoum
  0 siblings, 0 replies; 2+ messages in thread
From: Ahmad Fatoum @ 2023-09-26 19:52 UTC (permalink / raw)
  To: Tim Harvey, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel
  Cc: Conor Dooley, Krzysztof Kozlowski, Sascha Hauer, Rob Herring,
	NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam

Hello Tim,

On 26.09.23 21:44, Tim Harvey wrote:
> Fix the imx8mm-venice-gw72xx-0x-rpidsi dt overlay compatible string
> which should be gw,imx8mm-gw72xx-0x.
> 
> Fixes: 6b4da1354fd8 ("arm64: dts: imx8mm: add imx8mm-venice-gw72xx-0x-rpidsi overlay for display")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> index e0768d408c3b..2e4156b58108 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso
> @@ -11,7 +11,7 @@
>  /plugin/;
>  
>  &{/} {
> -	compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm";
> +	compatible = "gw,imx8mm-gw72xx-0x", "fsl,imx8mm";

Do you really want to fix up the compatible in the kernel device tree or was this
meant as a compatible for the overlay itself?

If it's the latter, you want to change above &{/} into / and use &{/}
only for the actual fragments below.

Cheers,
Ahmad


>  
>  	panel {
>  		compatible = "powertip,ph800480t013-idf02";

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-26 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 19:44 [PATCH] arm64: dts: imx8mm: fix imx8mm-venice-gw72xx-0x-rpidsi compatible Tim Harvey
2023-09-26 19:52 ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).