From: Ceclan Dumitru <mitrutzceclan@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ceclan Dumitru <dumitru.ceclan@analog.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO array size constraints
Date: Thu, 11 Jan 2024 10:17:58 +0200 [thread overview]
Message-ID: <478d9445-96aa-44b3-b598-8f7d7716dbba@gmail.com> (raw)
In-Reply-To: <20240110-unfitting-squander-b1d71c185bb7@spud>
On 1/10/24 18:17, Conor Dooley wrote:
> On Wed, Jan 10, 2024 at 05:37:09PM +0200, Dumitru Ceclan wrote:...
>> ctrl-gpios:
>> description:
>> - Must contain an array of 6 GPIO specifiers, referring to the GPIO pins
>> - connected to the control pins V1-V6.
>> - minItems: 6
>> + Must contain an array of GPIO specifiers, referring to the GPIO pins
>> + connected to the control pins.
>> + ADRF5740 - 4 GPIO connected to D2-D5
>> + HMC540S - 4 GPIO connected to V1-V4
>> + HMC425A - 6 GPIO connected to V1-V6
>> + minItems: 1
>> maxItems: 6
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: adi,hmc425a
>> + then:
>> + properties:
>> + ctrl-gpios:
>> + minItems: 6
>
>> + maxItems: 6
>
> This one should not be needed, it's already set by constraints on the
> property above.
>
No, not needed, just inspired from:
/bindings/clock/samsung,exynos7-clock.yaml
Specifically, the top constraints:
clocks:
minItems: 1
maxItems: 13
One of the conditional constraints:
clocks:
minItems: 13
maxItems: 13
I would only have two arguments for this staying here:
- It stays consistent with other cases
- In the case a new device with more than 6 GPIOs is added, this would
need to be put back in
next prev parent reply other threads:[~2024-01-11 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 15:37 [PATCH v2 0/4] Add support for LTC6373 Dumitru Ceclan
2024-01-10 15:37 ` [PATCH v2 1/4] dt-bindings: iio: hmc425a: add conditional GPIO array size constraints Dumitru Ceclan
2024-01-10 16:17 ` Conor Dooley
2024-01-11 8:17 ` Ceclan Dumitru [this message]
2024-01-11 16:31 ` Conor Dooley
2024-01-11 16:33 ` Conor Dooley
2024-01-13 15:36 ` Jonathan Cameron
2024-01-10 15:37 ` [PATCH v2 2/4] dt-bindings: iio: hmc425a: add entry for LTC6373 Dumitru Ceclan
2024-01-10 16:18 ` Conor Dooley
2024-01-10 15:37 ` [PATCH v2 3/4] iio: amplifiers: hmc425a: move conversion logic Dumitru Ceclan
2024-01-13 15:35 ` Jonathan Cameron
2024-01-10 15:37 ` [PATCH v2 4/4] iio: amplifiers: hmc425a: add support for LTC6373 Instrumentation Amplifier Dumitru Ceclan
2024-01-13 15:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478d9445-96aa-44b3-b598-8f7d7716dbba@gmail.com \
--to=mitrutzceclan@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dumitru.ceclan@analog.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).