From: Heiko Stuebner <heiko@sntech.de>
To: "Christoph Müllner" <christoph.muellner@theobroma-systems.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
shawn.lin@rock-chips.com, ulf.hansson@linaro.org,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Michal Simek <michal.simek@xilinx.com>,
Douglas Anderson <dianders@chromium.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Vicente Bergas <vicencb@gmail.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Randy Li <ayaka@soulik.info>, Tony Xie <tony.xie@rock-chips.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Lin Huang <hl@rock-chips.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.orglinux-
Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.
Date: Tue, 12 Mar 2019 14:17:55 +0100 [thread overview]
Message-ID: <4793843.T1TZ7EF8k3@phil> (raw)
In-Reply-To: <3BCC2A27-3AF4-4E5E-BBD4-6A5B49831D3C@theobroma-systems.com>
Am Freitag, 8. März 2019, 14:10:45 CET schrieb Christoph Müllner:
>
> > On 08.03.2019, at 13:46, Adrian Hunter <adrian.hunter@intel.com> wrote:
> >
> > On 7/03/19 10:43 AM, Christoph Muellner wrote:
> >> This patch documents the new property disable-cqe-dcmd
> >> for the Arasan eMMC 5.1 driver.
> >>
> >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >> ---
> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> >> index 1edbb049cccb..ec699bf98b7c 100644
> >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> >> @@ -44,6 +44,10 @@ Optional Properties:
> >> properly. Test mode can be used to force the controller to function.
> >> - xlnx,int-clock-stable-broken: when present, the controller always reports
> >> that the internal clock is stable even when it is not.
> >> + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs)
> >> + as part of the command queue engine (CQE). On controllers with a CQHCI,
> >> + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs.
> >> + This is done unless disable-cqe-dcmd is specified.
This needs a rewording please. See below for hw-description vs. driver, so
the description should be centered around why this is a property of the hw
[like faulty controller implementation or whatever]
> > If "supports-cqe" is in mmc.txt, should "disable-cqe-dcmd" be there also?
>
> The file mmc.txt says on top:
> "These properties are common to multiple MMC host controllers".
> As my patchset introduces "disable-cqe-dcmd" just for sdhci-of-arasan,
> I would say it should not go into that file.
>
> Also I wonder why "supports-cqe" is in mmc.txt, because
> only sdhci-tegra.c is evaluating that property.
> So I would expect it to be documented in
> Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
>
> However, I see that "disable-cqe-dcmd" could go into other drivers as well.
> But is this enough to document it in mmc.txt?
Devicetree is always about describing the hardware capabilites and never
about the actual nitty-gritty of driver implementation, aka it is not meant
as a space for hardware-independent config-settings or such.
As for only tegra evaluating this, is probably because it is still so new, like
january 2019 and Rob explicitly suggested it becoming common [0], which
suggests that the disable-cqe-dcmds should probably also be common.
Heiko
[0] https://lore.kernel.org/patchwork/patch/1031163/
next prev parent reply other threads:[~2019-03-12 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 8:43 [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Christoph Muellner
2019-03-07 8:43 ` [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd Christoph Muellner
2019-03-08 12:46 ` Adrian Hunter
2019-03-08 13:10 ` Christoph Müllner
2019-03-12 13:17 ` Heiko Stuebner [this message]
2019-03-12 14:46 ` Christoph Müllner
2019-03-12 17:10 ` Heiko Stübner
2019-03-12 17:16 ` Christoph Müllner
2019-03-12 19:28 ` Rob Herring
2019-03-07 8:43 ` [PATCH v2 3/3] arm64: dts: rockchip: Disable DCMDs on RK3399's eMMC controller Christoph Muellner
2019-03-08 12:47 ` [PATCH v2 1/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4793843.T1TZ7EF8k3@phil \
--to=heiko@sntech.de \
--cc=adrian.hunter@intel.com \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=hl@rock-chips.com \
--cc=kernel@esmil.dk \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.orglinux- \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tony.xie@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=vicencb@gmail.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).