From: David Lechner <dlechner@baylibre.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>,
jic23@kernel.org, robh@kernel.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v7 3/8] iio: backend: add API for oversampling
Date: Wed, 4 Dec 2024 18:44:34 -0600 [thread overview]
Message-ID: <4795d5b2-2d6d-4d81-a57b-dc28d217aacf@baylibre.com> (raw)
In-Reply-To: <20241129153546.63584-4-antoniu.miclaus@analog.com>
On 11/29/24 9:35 AM, Antoniu Miclaus wrote:
> Add backend support for enabling/disabling oversampling.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v7:
> - implement 2 callbacks
> iio_backend_oversampling_enable()
> iio_backend_oversampling_disable()
I think Jonathan's suggestion from a previous review to pass the
oversampling ratio instead of enable/disable seems like a good idea
for making this more generic.
int iio_backend_set_oversampling_ratio(struct iio_backend *back, u32 ratio);
To answer Jonathan's question [1] about why does the backend need to
know if oversampling is enabled or not... In this case, it looks
like it changes some timing (the conversion quiet time) on the LVDS/CMOS
serial data lines depending on if oversampling is enabled or not.
[1]: https://lore.kernel.org/linux-iio/20241123160559.56c57fc7@jic23-huawei/
next prev parent reply other threads:[~2024-12-05 0:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 15:35 [PATCH v7 0/8] Add support for AD485x DAS Family Antoniu Miclaus
2024-11-29 15:35 ` [PATCH v7 1/8] iio: backend: add API for interface get Antoniu Miclaus
2024-11-29 15:35 ` [PATCH v7 2/8] iio: backend: add support for data size set Antoniu Miclaus
2024-11-29 15:35 ` [PATCH v7 3/8] iio: backend: add API for oversampling Antoniu Miclaus
2024-12-05 0:44 ` David Lechner [this message]
2024-11-29 15:35 ` [PATCH v7 4/8] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-11-29 15:35 ` [PATCH v7 5/8] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-12-05 0:45 ` David Lechner
2024-12-09 13:58 ` Miclaus, Antoniu
2024-11-29 15:35 ` [PATCH v7 6/8] iio: adc: adi-axi-adc: add oversampling Antoniu Miclaus
2024-11-29 15:35 ` [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851 Antoniu Miclaus
2024-12-05 0:46 ` David Lechner
2024-12-09 14:02 ` Miclaus, Antoniu
2024-12-09 17:44 ` David Lechner
2024-11-29 15:35 ` [PATCH v7 8/8] iio: adc: ad4851: add ad485x driver Antoniu Miclaus
2024-11-30 11:19 ` kernel test robot
2024-11-30 17:06 ` Jonathan Cameron
2024-12-05 0:47 ` David Lechner
2024-12-07 15:29 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4795d5b2-2d6d-4d81-a57b-dc28d217aacf@baylibre.com \
--to=dlechner@baylibre.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox